[BE] refactor: 트랜잭션을 팀 컨벤션에 맞게 리팩터링 (#291)

woowacourse-teams · Aug 3, 2023 · d127270 · d127270
1 parent fd15941
commit d127270
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/backend/src/main/java/com/funeat/auth/application/AuthService.java b/backend/src/main/java/com/funeat/auth/application/AuthService.java
@@ -8,7 +8,7 @@
 import org.springframework.transaction.annotation.Transactional;
 
 @Service
-@Transactional
+@Transactional(readOnly = true)
 public class AuthService {
 
     private final MemberService memberService;

diff --git a/backend/src/main/java/com/funeat/member/application/MemberService.java b/backend/src/main/java/com/funeat/member/application/MemberService.java
@@ -1,7 +1,5 @@
 package com.funeat.member.application;
 
-import static org.springframework.transaction.annotation.Propagation.REQUIRES_NEW;
-
 import com.funeat.auth.dto.SignUserDto;
 import com.funeat.auth.dto.UserInfoDto;
 import com.funeat.member.domain.Member;
@@ -12,7 +10,7 @@
 import org.springframework.transaction.annotation.Transactional;
 
 @Service
-@Transactional
+@Transactional(readOnly = true)
 public class MemberService {
 
     private final MemberRepository memberRepository;
@@ -21,6 +19,7 @@ public MemberService(final MemberRepository memberRepository) {
         this.memberRepository = memberRepository;
     }
 
+    @Transactional
     public SignUserDto findOrCreateMember(final UserInfoDto userInfoDto) {
         final String platformId = userInfoDto.getId().toString();
 
@@ -29,8 +28,7 @@ public SignUserDto findOrCreateMember(final UserInfoDto userInfoDto) {
                 .orElseGet(() -> save(userInfoDto));
     }
 
-    @Transactional(propagation = REQUIRES_NEW)
-    public SignUserDto save(final UserInfoDto userInfoDto) {
+    private SignUserDto save(final UserInfoDto userInfoDto) {
         final Member member = userInfoDto.toMember();
         memberRepository.save(member);