fix: 리뷰 삭제시 썸네일 업데이트 로직 순서 변경 (#815)

woowacourse-teams · Oct 19, 2023 · 48a20c9 · 48a20c9
1 parent 800f563
commit 48a20c9
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/backend/src/main/java/com/funeat/review/application/ReviewService.java b/backend/src/main/java/com/funeat/review/application/ReviewService.java
@@ -247,19 +247,13 @@ public void deleteReview(final Long reviewId, final Long memberId) {
 
         if (review.checkAuthor(member)) {
             eventPublisher.publishEvent(new ReviewDeleteEvent(image));
-            updateProduct(product, review.getRating());
             deleteThingsRelatedToReview(review);
+            updateProduct(product, review.getRating());
             return;
         }
         throw new NotAuthorOfReviewException(NOT_AUTHOR_OF_REVIEW, memberId);
     }
 
-    private void updateProduct(final Product product, final Long deletedRating) {
-        updateProductImage(product.getId());
-        product.updateAverageRatingForDelete(deletedRating);
-        product.minusReviewCount();
-    }
-
     private void deleteThingsRelatedToReview(final Review review) {
         deleteReviewTags(review);
         deleteReviewFavorites(review);
@@ -282,6 +276,12 @@ private void deleteReviewFavorites(final Review review) {
         reviewFavoriteRepository.deleteAllByIdInBatch(ids);
     }
 
+    private void updateProduct(final Product product, final Long deletedRating) {
+        product.updateAverageRatingForDelete(deletedRating);
+        product.minusReviewCount();
+        updateProductImage(product.getId());
+    }
+
     public Optional<MostFavoriteReviewResponse> getMostFavoriteReview(final Long productId) {
         final Product findProduct = productRepository.findById(productId)
                 .orElseThrow(() -> new ProductNotFoundException(PRODUCT_NOT_FOUND, productId));