-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 검색 기능을 최적화한다 #928
Open
feb-dain
wants to merge
5
commits into
develop
Choose a base branch
from
refactor/927
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import { useEffect, useCallback } from 'react'; | ||
|
||
export const useDebounce = <T>(func: (param: T) => void, dependencies: string[], delay: number) => { | ||
const callback = useCallback(func, dependencies); | ||
const callback = useCallback(func, [delay]); | ||
|
||
useEffect(() => { | ||
const timeout = setTimeout(callback, delay); | ||
|
||
return () => clearTimeout(timeout); | ||
}, [callback, delay]); | ||
}, [callback, dependencies]); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전 검색시 사용했던 검색어를 변화하는 현재 검색어와 비교해 같은 검색어는 새로운 요청을 발생시키지 않도록 하기 위해서 새로운 상태를 두어 해당 값을 캐시로 활용하고 계신거 같네요! 제가 이해한 내용이 맞다면 추가적인 상태를 늘려 훅의 복잡도가 높아질 여지가 있진 않을까 하는 생각이 듭니다.
현재 코드를 보면 검색 결과에 대한 쿼리를 등록하고 있으므로 해당 쿼리키에 해당하는 캐시 값이 있는지 여부를 통해 이전에 검색했던 값인지를 알아올 수도 있을 것 같아요! 아래 링크에 있는 메서드(
queryClient.getQueryData
)를 활용해도 괜찮을 것 같습니다 👍쿼리키를 통해 캐시값을 읽어오는 메서드 참고 문서