forked from woowacourse/jwp-shopping-cart
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
짱바구니2 #13
Open
woo-chang
wants to merge
63
commits into
woowacourse-code-review-study:main
Choose a base branch
from
woo-chang:step2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
짱바구니2 #13
Commits on Apr 28, 2023
-
[1단계 - 상품 관리 기능] 다즐(최우창) 미션 제출합니다. (woowacourse#221)
* docs: README.md 기능 목록 작성 * chore: DB 설정 추가 * feat: 상품, 카테고리, 상품카테고리 DB 테이블 설계 * test: DB 연결 테스트 * feat: 상품명을 검증하는 Name 객체 구현 * feat: 이미지 경로를 검증하는 ImageUrl 객체 구현 * refactor: ParameterizedTest name 필드 추가 * feat: 상품 가격을 검증하는 Price 객체 구현 * feat: 상품 설명을 검증하는 Description 객체 구현 * feat: ProductEntity 구현 * feat: CategoryEntity 구현 * refactor: 카테고리 디폴트 값으로 초기화 * refactor: ID LONG 타입으로 변경 * feat: ProductCategoryEntity 구현 * docs: DB 테이블과 엔티티 구현 완료 * feat: CategoryDao 구현 * feat: ProductDao 구현 * feat: ProductDao 전체 조회 기능 구현 * feat: ProductDao 삭제 기능 구현 * refactor: equals&hashCode 재정의 * refactor: Id null 검증 로직 추가 * refactor: equals&hashCode 메서드 위치 변경 * feat: 상품 Id로 조회 기능 추가 * feat: 상품 수정 기능 추가 * feat: ProductCategoryDao 구현 * feat: 상품카테고리 조회 기능 구현 * refactor: Id null 검증 로직 추가 * feat: 상품 카테고리 삭제 기능 구현 * docs: 사용하지 않는 기능 삭제 * feat: 상품 생성 비즈니스 로직 구현 * feat: 상품 목록 조회 비즈니스 로직 추가 * feat: 상품 정보 수정 비즈니스 로직 추가 * feat: 상품 정보 수정 비즈니스 로직 추가 * feat: 상품 정보 삭제 비즈니스 로직 구현 * feat: 상품 생성 컨트롤러 API 메서드 구현 * feat: 상품 업데이트 컨트롤러 API 메서드 구현 * feat: 상품 삭제 컨트롤러 API 메서드 구현 * refactor: 클래스에 final 키워드 사용 * refactor: 프록시를 생성하는 객체에 한하여 final 키워드 제거 * feat: 페이지 생성 컨트롤러 구현 * feat: 상품 조회 컨트롤러 API 메서드 구현 * feat: 상품 정보 출력, 입력 뷰 수정 * refactor: 동적 뷰 생성 로직 수정 * refactor: 서비스 메서드 트랜잭션 적용 * refactor: 상품 테이블 이미지URL 컬럼 TEXT 타입으로 변경 * feat: ExceptionAdvice 객체 구현 * feat: Spring Validation 기능 추가 * refactor: 초기 카테고리에 없음 추가 * refactor: 검증 역할 서비스로 이동 * refactor: 이미지 URL 길이 제한 제거 * chore: 불필요한 출력문 제거 * feat: 서버 로그 추가 * refactor: 불필요한 imageUrl 테스트 제거 * refactor: 코드 컨벤션 수정 * feat: 서버 예외 처리 기능 구현 --------- Co-authored-by: splitube <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b16371c - Browse repository at this point
Copy the full SHA b16371cView commit details
Commits on Apr 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e14cbc5 - Browse repository at this point
Copy the full SHA e14cbc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8288867 - Browse repository at this point
Copy the full SHA 8288867View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb1f224 - Browse repository at this point
Copy the full SHA eb1f224View commit details -
Configuration menu - View commit details
-
Copy full SHA for 497ca0f - Browse repository at this point
Copy the full SHA 497ca0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b66c51 - Browse repository at this point
Copy the full SHA 0b66c51View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac137d3 - Browse repository at this point
Copy the full SHA ac137d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 111760e - Browse repository at this point
Copy the full SHA 111760eView commit details
Commits on Apr 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 31133b8 - Browse repository at this point
Copy the full SHA 31133b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63bdc49 - Browse repository at this point
Copy the full SHA 63bdc49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cbf94 - Browse repository at this point
Copy the full SHA 12cbf94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dfc96a - Browse repository at this point
Copy the full SHA 0dfc96aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 589af6d - Browse repository at this point
Copy the full SHA 589af6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a4b5f6 - Browse repository at this point
Copy the full SHA 3a4b5f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for aeadd1d - Browse repository at this point
Copy the full SHA aeadd1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a18eb - Browse repository at this point
Copy the full SHA 34a18ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0754a - Browse repository at this point
Copy the full SHA 0c0754aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19de642 - Browse repository at this point
Copy the full SHA 19de642View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdddba8 - Browse repository at this point
Copy the full SHA cdddba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a43954 - Browse repository at this point
Copy the full SHA 7a43954View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b0c55 - Browse repository at this point
Copy the full SHA d6b0c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7862a - Browse repository at this point
Copy the full SHA 2d7862aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 363cc1e - Browse repository at this point
Copy the full SHA 363cc1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 284385a - Browse repository at this point
Copy the full SHA 284385aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f8a694 - Browse repository at this point
Copy the full SHA 4f8a694View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a9dfef - Browse repository at this point
Copy the full SHA 1a9dfefView commit details
Commits on May 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3726e7a - Browse repository at this point
Copy the full SHA 3726e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0579256 - Browse repository at this point
Copy the full SHA 0579256View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c6332 - Browse repository at this point
Copy the full SHA f6c6332View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9acb79a - Browse repository at this point
Copy the full SHA 9acb79aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec56ce0 - Browse repository at this point
Copy the full SHA ec56ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 525159b - Browse repository at this point
Copy the full SHA 525159bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ccbfa - Browse repository at this point
Copy the full SHA 96ccbfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 769265f - Browse repository at this point
Copy the full SHA 769265fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f6d8b6 - Browse repository at this point
Copy the full SHA 9f6d8b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5235fb1 - Browse repository at this point
Copy the full SHA 5235fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a78b10 - Browse repository at this point
Copy the full SHA 7a78b10View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3c6a78 - Browse repository at this point
Copy the full SHA e3c6a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7ee380 - Browse repository at this point
Copy the full SHA c7ee380View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d5f4e - Browse repository at this point
Copy the full SHA a8d5f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 498b2b6 - Browse repository at this point
Copy the full SHA 498b2b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd3136 - Browse repository at this point
Copy the full SHA 5bd3136View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12401ed - Browse repository at this point
Copy the full SHA 12401edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56cc7b8 - Browse repository at this point
Copy the full SHA 56cc7b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cada63e - Browse repository at this point
Copy the full SHA cada63eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f99b0d2 - Browse repository at this point
Copy the full SHA f99b0d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for af5ed16 - Browse repository at this point
Copy the full SHA af5ed16View commit details
Commits on May 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a95189e - Browse repository at this point
Copy the full SHA a95189eView commit details
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7649bee - Browse repository at this point
Copy the full SHA 7649beeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d94688a - Browse repository at this point
Copy the full SHA d94688aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1253d26 - Browse repository at this point
Copy the full SHA 1253d26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1177617 - Browse repository at this point
Copy the full SHA 1177617View commit details
Commits on May 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8d2b18d - Browse repository at this point
Copy the full SHA 8d2b18dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a1fc2 - Browse repository at this point
Copy the full SHA 77a1fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45829df - Browse repository at this point
Copy the full SHA 45829dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0d0f83 - Browse repository at this point
Copy the full SHA b0d0f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for d744d5d - Browse repository at this point
Copy the full SHA d744d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dfcec3 - Browse repository at this point
Copy the full SHA 6dfcec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4f869 - Browse repository at this point
Copy the full SHA fc4f869View commit details -
Configuration menu - View commit details
-
Copy full SHA for aeba896 - Browse repository at this point
Copy the full SHA aeba896View commit details
Commits on May 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5d58d60 - Browse repository at this point
Copy the full SHA 5d58d60View commit details -
Configuration menu - View commit details
-
Copy full SHA for bddcd33 - Browse repository at this point
Copy the full SHA bddcd33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c23479 - Browse repository at this point
Copy the full SHA 6c23479View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.