박자스동터차 경주 2단계 #8

drunkenhw · 2023-04-19T05:45:18Z

No description provided.

* feat: 자동차 경주 코드 가져오기 * feat: 웹 요청,응답 구현 * feat: service 분리 * feat: 데이터베이스 연결 * feat: table 추가 * feat: 데이터베이스 저장하는 기능 구현 * test: car dao 테스트 추가 * test: racing game dao 테스트 추가 * test: racing game service 테스트 추가 * test: transactional 어노테이션 추가 * test: service test 리팩터링 * test: controller test 추가

be-student

화이팅 뭘 저렇게 많이 적었냐

be-student · 2023-04-23T04:16:40Z

src/main/java/racingcar/domain/Car.java

+    private void validateLength(String name) {
+        if (name.length() > MAX_NAME_LENGTH) {
+            throw new IllegalArgumentException("이름이 " + name.length() + "자 입니다. " + "이름은 5자 이하로 가능합니다.");
+        }
+    }


이 부분은 name 쪽으로 가도 좋을지도?

private final Name name;

be-student · 2023-04-23T04:17:51Z

src/main/java/racingcar/domain/Cars.java

+    }
+
+    private void validateDuplicateName(List<Car> cars) {
+        Set<String> distinctNames = cars.stream()


set 보다는 distinct 쪽이 더 좋을 것 같아보이기도 하고 아닌것 같기도 하고 어떻게 생각해?

be-student · 2023-04-23T04:20:34Z

src/main/java/racingcar/domain/RacingGame.java

+
+    private final NumberGenerator numberGenerator;
+    private final Cars cars;
+    private int tryCount;


이것도 객체로 빼도 괜찮아보이는데?

private final TryCount tryCount;

원시값 포장 느낌으로

be-student · 2023-04-23T04:20:47Z

src/main/java/racingcar/domain/RandomNumberGenerator.java

+
+    @Override
+    public int generate() {
+        return (int) (Math.random() * BOUND);


Math.random() 을 사용한 이유는?

be-student · 2023-04-23T04:21:15Z

src/main/java/racingcar/dto/CarDto.java

@@ -0,0 +1,20 @@
+package racingcar.dto;
+
+public class CarDto {


네이밍이 CarResponse 가 아닌 이유가 뭐야?
응답에서만 쓰이는 것 같은데

be-student · 2023-04-23T04:45:07Z

src/test/java/racingcar/dao/CarJdbcDaoTest.java

+    void findByGameId() {
+        List<CarEntity> carEntities = carDao.findByRacingGameId(gameId);
+
+        assertThat(carEntities).hasSize(2);


이거 조금 더 자세하게 내부 데이터 검증해도 괜찮을거 같은데?

be-student · 2023-04-23T04:45:18Z

src/test/java/racingcar/controller/RacingGameControllerTest.java

+import racingcar.dto.RacingGameResponse;
+import racingcar.service.RacingGameService;
+
+@WebMvcTest(RacingGameController.class)


webmvc test 굿

be-student · 2023-04-23T04:46:04Z

src/test/java/racingcar/controller/RacingGameControllerTest.java

+                List.of("현구막"),
+                List.of(new CarDto("현구막", 10), new CarDto("박스터", 7))
+        );


현구막이 이렇게 많이 나오다니 부럽네요

be-student · 2023-04-23T04:47:30Z

src/main/java/racingcar/RacingCarConsoleApplication.java

+    static class InnerRacingGameDao implements RacingGameDao {
+        private final Map<Long, RacingGameEntity> database = new HashMap<>();
+        private Long id = 1L;
+
+        @Override
+        public Long save(RacingGameEntity racingGameEntity) {
+            database.put(id, racingGameEntity);
+            id++;
+            return id - 1;
+        }
+
+        @Override
+        public List<RacingGameEntity> findAllByCreatedTimeAsc() {
+            return database.values()
+                    .stream().sorted(Comparator.comparing(RacingGameEntity::getCreatedTime))
+                    .collect(Collectors.toList());
+        }
+    }


웨 static class?

be-student · 2023-04-23T04:48:40Z

src/main/java/racingcar/service/RacingGameService.java

+    }
+
+    public RacingGameResponse play(RacingGameRequest racingGameRequest) {
+        Cars cars = toCars(racingGameRequest);


서비스 제일 앞에서 dto 뽀개는거 굿

woo-chang

수고하셨습니다 박스터 🫡

많이 배워갑니다 🔥

woo-chang · 2023-04-23T11:49:24Z

src/main/java/racingcar/controller/RacingGameController.java

+        this.racingGameAddService = racingGameService;
+        this.racingGameFindService = racingGameFindService;


Command와 Query를 분리하셨네요 👍

woo-chang · 2023-04-23T11:52:04Z

src/main/java/racingcar/dao/entity/CarEntity.java

@@ -0,0 +1,32 @@
+package racingcar.dao.entity;
+
+public class CarEntity {


Entity를 식별할 수 있는 식별자가 없는 것 같은데 의도하신걸까요? 🤔

woo-chang · 2023-04-23T11:58:15Z

src/main/java/racingcar/dto/RacingGameRequest.java

+
+public class RacingGameRequest {
+
+    @Size(min = 2, message = "참가자는 최소 2명이여야 합니다")


예외 메시지까지 설정한 거 좋은데요 👍

woo-chang · 2023-04-23T12:00:09Z

src/main/java/racingcar/service/RacingGameAddService.java

+        RacingGame racingGame = new RacingGame(racingGameRequest.getCount(), cars);
+        racingGame.run();
+
+        Long racingGameId = racingGameDao.save(new racingcar.dao.entity.RacingGameEntity(racingGameRequest.getCount()));


RacingGameEntity를 이렇게 import 하는 이유가 궁금합니다!

woo-chang · 2023-04-23T12:03:02Z

src/main/java/racingcar/service/RacingGameAddService.java

+import racingcar.dto.RacingGameResponse;
+
+@Service
+public class RacingGameAddService {


조회에 @Transactional 어노테이션을 사용한만큼 통일성 있게 여기도 사용하는건 어떨까요?

woo-chang · 2023-04-23T12:03:58Z

src/test/java/racingcar/controller/RacingGameControllerTest.java

+                List.of(new CarDto("현구막", 10), new CarDto("박스터", 7))
+        );
+        String requestString = objectMapper.writeValueAsString(request);
+        when(racingGameService.play(any())).thenReturn(expectedResponse);


Mockito와 BDDMockito를 선택하는 기준이 궁금합니다~

woo-chang · 2023-04-23T12:04:16Z

src/test/java/racingcar/controller/RacingGameControllerTest.java

+                .andExpect(status().isCreated())
+                .andExpect(jsonPath("$.winners[0]", is("현구막")))
+                .andExpect(jsonPath("$.racingCars", hasSize(2)));


꼼꼼한 응답 결과 검증 굳

woo-chang · 2023-04-23T12:07:03Z

src/test/java/racingcar/dao/RacingGameJdbcDaoTest.java

+        String sql = "SELECT trial_count FROM racing_game WHERE id = " + gameId;
+        Integer savedTrialCount = jdbcTemplate.queryForObject(sql, Integer.class);


쿼리를 직접 날려확인하기보다는 findAllByCreatedTimeAsc 메서드를 활용해 테스트하는건 어떨까요?

drunkenhw and others added 22 commits April 14, 2023 12:28

refactor: domain에서 spring 의존성 제거

479dd33

refactor: save all 메서드 batch update로 변경

fa3f081

refactor: 불필요한 어노테이션 변경

11d31ed

test: controller 단위 테스트 추가

314f00d

test: display name 추가

6a0e142

refactor: db접근을 위한 entity 추가

95f6855

feat: 객체 검증 기능 추가

ca7c8d6

refactor: racing game test 가독성 좋게 수정

06abb19

refactor: 출력 형식에 맞도록 수정

ce71dda

refactor: racing game 방식 변경

1e63c66

refactor: 승자를 구하는 로직 추가

ce96d76

feat: racing game을 조회하는 기능 추가

6ba3533

feat: racing game id로 car를 조회하는 기능 추가

39d4e46

feat: 전체 결과를 조회하여 결과를 반환하는 기능 추가

1b31c3c

feat: api 추가

c4a600c

feat: 예외 처리 컨트롤러 추가

35f4996

feat: 콘솔 게임 기능 추가

068f395

feat: In memory Dao 추가

578e675

refactor: simpleJdbcInsert를 사용하도록 변경

06b0608

refactor: 최상위 예외를 잡는 메서드 추가

e886c52

refactor: 프론트에서 List로 반환하도록 변경

a5de3c2

be-student reviewed Apr 23, 2023

View reviewed changes

drunkenhw added 5 commits April 23, 2023 15:19

refactor: service 클래스 분리

04bb0d8

refactor: rest api 응답 형식으로 변경

7fada27

feat: valid를 통한 검증 추가

6fda343

refactor: 결과를 조회하는 서비스에 transactional 추가

f7d899e

refactor: 예외 처리 문구 수정

3b99dd9

woo-chang approved these changes Apr 23, 2023

View reviewed changes

refactor: trasactional 어노테이션 추가

9cf0152

drunkenhw added 3 commits April 24, 2023 14:18

refactor: racing game을 수행하는 클래스 추가

dcf1b6d

refactor: racing game console 서비스 클래스 제거

ea55c02

refactor: racing game play 서비스 클래스 제거

d46221c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

박자스동터차 경주 2단계 #8

박자스동터차 경주 2단계 #8

drunkenhw commented Apr 19, 2023

be-student left a comment

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

be-student Apr 23, 2023

woo-chang left a comment

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

woo-chang Apr 23, 2023

		this.racingGameAddService = racingGameService;
		this.racingGameFindService = racingGameFindService;

		@@ -0,0 +1,32 @@
		package racingcar.dao.entity;

		public class CarEntity {


		public class RacingGameRequest {

		@Size(min = 2, message = "참가자는 최소 2명이여야 합니다")

		String sql = "SELECT trial_count FROM racing_game WHERE id = " + gameId;
		Integer savedTrialCount = jdbcTemplate.queryForObject(sql, Integer.class);

박자스동터차 경주 2단계 #8

Are you sure you want to change the base?

박자스동터차 경주 2단계 #8

Conversation

drunkenhw commented Apr 19, 2023

be-student left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woo-chang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment