-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 락을 활용하여 동시성 문제가 일어나지 않는 예매 기능을 구현한다. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 사용자 검증이 필요하므로 LoginMember 정보를 메소드 인자에 추가
seminchoi
requested review from
mirageoasis,
hseong3243 and
lass9436
as code owners
August 16, 2024 08:01
Co-authored-by: 박혜성 <[email protected]>
개선된 패키지에서 기존 클래스를 사용하기 위해 패키지 이동함. Co-authored-by: 박혜성 <[email protected]>
개선된 패키지에서 기존 클래스를 사용하기 위해 패키지 이동함. Co-authored-by: 박혜성 <[email protected]>
Co-authored-by: 박혜성 <[email protected]>
Co-authored-by: 박혜성 <[email protected]>
- reddison 이라고 네이밍 되어있던 클래스 및 변수 네이밍 수정
- 파라미터에 @param 어노테이션을 이용해 주입 할 변수 명시
구조 변경으로 기존 레디스 클래스를 더 이상 사용하지 않아 관련 config 클래스를 제거함.
레디스 set 자료구조를 이용해 구현함. 현재 작업 중인 인원 목록을 관리함.
이제 사용하지 않는 테스트에 `@Disabled` 어노테이션을 추가함.
`WaitingRoom`이 가지는 대기열, 대기 번호 발급의 책임을 별도의 인터페이스로 분리함.
`RunningRoom`이 가지는 작업 가능 공간 입장 카운트의 책임을 별도의 인터페이스로 분리함.
hseong3243
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
📝 작업 요약
동시성 문제가 발생하지 않는 티켓 예매 기능을 구현했습니다.
💡 관련 이슈