-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 구역의 좌석목록을 조회하는 API를 구현한다. #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 더 직관적으로 이해하기 쉽게 네이밍 변경
seminchoi
requested review from
mirageoasis,
hseong3243 and
lass9436
as code owners
August 13, 2024 10:54
hseong3243
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 확인해주시고 머지 하면 될것 같아요!
src/main/java/com/thirdparty/ticketing/domain/seat/dto/response/SeatElement.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thirdparty/ticketing/domain/seat/controller/SeatControllerTest.java
Outdated
Show resolved
Hide resolved
- 객체 지향적으로 메세지를 전달하기 위해 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
구역의 좌석 목록을 조회하는 API를 구현했습니다.
구현한 API의 rest docs 를 작성했습니다.
좌석 관련 dto 패키지를 request, response 패키지로 분리했습니다.
@Transcational
붙지 않은 로직에 트랜잭션을 붙였습니다.📝 작업 요약
구역의 좌석목록을 조회하는 API 구현
💡 관련 이슈