Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using several git repos #65

Closed
wants to merge 1 commit into from

Conversation

ochurlaud
Copy link
Contributor

Fixes #47

@mhoffrog
Copy link
Collaborator

Hello @ochurlaud, @woolfg - regarding support for multiple repos, this pull request is partially overlapping with my pending pull request #56. But this request is implementing a nice and more generic approach by auto determining existing repos for the file path of the current artifact being saved. So I will take care of reviewing both pull requests to create a merge covering the features of both pull requests to provide backward compatibility as well as minimal additional configuration for a new plugin version.

action/editcommit.php Show resolved Hide resolved
@mhoffrog mhoffrog added the awaiting further analysis Supposed for pull requests requiring further fixes or issue analysis label Feb 6, 2022
@ochurlaud
Copy link
Contributor Author

ochurlaud commented Feb 7, 2022

@woolfg I would need answer to the previous questions to move forward. I don't want to radically change the paradigm of this plugin without your opinion, but I think that if we follow the multi-repo idea, we need to make a design choice. Either the user knows all the repos, and we should do a namespace-oriented design (for instance with the git repos at the root of the first level namespace) or something completely agnostic, and in this case, remove a the pull features and only deal with pushes.

Both will work for me, but I think the latter is simpler to develop and I kind of lean towards this one (as I would rather have cron jobs to pull regularly, or add services to pull on webhooks : it scales well better with complex infrastructure like I tend to have with CI and so on).

@mhoffrog
Copy link
Collaborator

mhoffrog commented Feb 8, 2022

@ochurlaud please have a look at my reply (#65 (comment)). I fully agree with your thoughts and cases, but regarding the pull configuration, we have to consider backward compatibility of existing installations - and there are a few out so far.
The explicit configurations repoPath abd repoWorkDir will become obsolete by this merge now. So we could mark the configurations as deprecated and point this out in the documentation as well as in the configuration items description for a while.
@woolfg FYI

@ochurlaud
Copy link
Contributor Author

@ochurlaud ochurlaud closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting further analysis Supposed for pull requests requiring further fixes or issue analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to use multple git repos?
2 participants