feat: Update context menu entry if no profiles #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will review tonight. |
woodruffw
reviewed
Jan 24, 2024
ff2mpv.js
Outdated
| } | ||
| } | ||
|
|
||
| function createProfile(profile) { | ||
| let os = ''; |
There was a problem hiding this comment.
This mutable global state feels a little funny -- can't we call getOS twice or, even better, call it just once to set a global TITLE constant based on the right host?
There was a problem hiding this comment.
I've defined TITLE as a global variable. Let me know if it looks better know.
woodruffw
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to change to a single entry in context menu if no profiles.
Solves: #114