Include the prefix /opt/homebrew/bin in the PATH for installations that were performed for arch arm64 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at were performed for arch arm64
woodruffw
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM, thanks @claudiofreitas!
Technically we could split this out a bit by checking RbConfig::CONFIG["host_cpu"] as well, but this is also fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think for some reasons, previous Mac Silicons had the homebrew still installing applications under
/usr/local/bin.When not installed under Rosetta, it will default the location to
/opt/homebrewaccording to the documentation.ff2mpv was not working for me until I added this change to the PATH.
I am not used to contribute a lot to open source, so let me know if there are any changes that are desired please.