Do not require agent polling to make workflows that should be skipped done #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
commented
Oct 28, 2024
qwerty287
changed the title
6543
added
the
build_pr_images
3 tasks
|
todo: check that "virtual" agent is neither in database nor in webui/api visible |
|
PS: once we refactored more of the queue related code we might have a chance to simplify it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we have in the task poll logic an check that clean up the queue of tasks that should be skipped.
so it requires agents to poll to actually do stuff.
but the agent poll logic should ignore all tasks that are not ready to run and the queue maintenance should happen in an dedicated place.
this pull starts to refactor this by at least move it in it's own function and go routine in the background.