[Woo POS - payments onboarding] Enable POS for stores with incomplete payments onboarding #14149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14147
Why
As in the project kickoff pdfdoF-5Bo-p2, I'm starting the project by adding a feature flag and enabling POS for stores with incomplete payments onboarding state behind the feature flag. I decided to add a feature flag so that it doesn't break the Installable Builds (used for Woo DM demo, if some people on the team try updating the app version) and the work is minimal.
How
paymentsOnboardingInPointOfSale
, this will be removed when the project is completedPOSEligibilityChecker
, the onboarding completed state condition is removed when the onboardingfeature flag is enabledPOSEligibilityChecker
changesThere are also two small commits at the beginning where I removed unused properties while I was looking into the code. Unused code could be confusing during code search and removing it would reduce the time spent searching for its usage.
Steps to reproduce
Stores with onboarding completed
Prerequisite: the store is eligible for POS (US store, USD, WC v6.6+), and payments onboarding is completed (in Menu > Payments, no
Continue setup
banner is shown at the bottom)Point of Sale Mode
row should appear as beforePoint of Sale Mode
Connect your reader
--> connection flow should work as beforeStores with incomplete onboarding
Prerequisite: the store is eligible for POS (US store, USD, WC v6.6+), but payments onboarding is not completed (in Menu > Payments,
Continue setup
banner is shown at the bottom, or not using Woo Payments)Point of Sale Mode
row should appear (it shouldn't appear when the feature flag is off)Point of Sale Mode
Connect your reader
--> no-op for now, onboarding UI will be integrated in [Woo POS - payments onboarding] Show payments onboarding from existing design #14148Testing information
I tested on iPad Pro 11in (M4) iOS 17.5 simulator with Xcode 16.
Screenshots
Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2024-10-18.at.14.21.07.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: