Google Ads: Add eligibility check for campaign creation #13192
Conversation
itsmeichigo
added
type: task
|
|
itsmeichigo
changed the base branch from
trunk
to
task/13182-yosemite-fetch-gla-campaigns
| self.featureFlagService = featureFlagService | ||
| } | ||
|
|
||
| func isSiteEligible(siteID: Int64) async -> Bool { |
There was a problem hiding this comment.
❓ Should we mark this as MainActor? Also, I think marking the protocol method as MainActor doesn't really check the MainActor conformance here.
There was a problem hiding this comment.
@selanthiraiyan Actually marking the protocol method with @MainActor ensures that all conformance method are on the main actor. I learned this when attempting to do the migration for Swift 6, so I figured it's better to do it correctly now than to fix it later in the migration process.
There was a problem hiding this comment.
Actually marking the protocol method with @mainactor ensures that all conformance method are on the main actor.
That is great. TIL. Thanks.
|
|
||
| let isPluginSatisfied: Bool = await { | ||
| if let savedPlugin = await fetchPluginFromStorage(siteID: siteID) { | ||
| return checkIfGoogleAdsIsSupported(plugin: savedPlugin) |
There was a problem hiding this comment.
❓ Should we fetch the plugin from remote in case the plugin version has been updated recently and it isn't synched to storage yet?
This is an edge case considering that we fetch plugin info upon app launch.
There was a problem hiding this comment.
@selanthiraiyan do you mean we should always fetch from remote rather than relying on storage?
There was a problem hiding this comment.
do you mean we should always fetch from remote rather than relying on storage?
We can fetch from remote only when the local plugin version doesn't match the required pluginMinimumVersion. This covers the case in which the user has updated the plugin version recently but we haven't fetched the new version details. This is an edge case and please feel free to ignore it.
There was a problem hiding this comment.
I think it is safer to always fetch plugins from remote to avoid edge cases. Updated in 5f0f3ea. Thanks Sharma for the suggestion!
Closes: #13190
Description
This PR adds an eligibility checker to decide whether to display the entry point to Google ads campaign creation on the app. The logic includes:
googleAdsCampaignCreationOnWebViewto ensure that it's enabled.Testing steps
The eligibility check has not been used anywhere, so just unit tests passing is sufficient.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.