-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Woo POS] Extract item selection logic to
ItemSelectorViewModel (#1…
- Loading branch information
Showing
7 changed files
with
174 additions
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
WooCommerce/Classes/POS/ViewModels/ItemSelectorViewModel.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import Combine | ||
| import SwiftUI | ||
| import protocol Yosemite.POSItem | ||
| import protocol Yosemite.POSItemProvider | ||
|
|
||
| final class ItemSelectorViewModel: ObservableObject { | ||
| let selectedItemPublisher: AnyPublisher<POSItem, Never> | ||
|
|
||
| @Published private(set) var items: [POSItem] = [] | ||
| @Published private(set) var isSyncingItems: Bool = true | ||
|
|
||
| private let itemProvider: POSItemProvider | ||
| private let selectedItemSubject: PassthroughSubject<POSItem, Never> = .init() | ||
|
|
||
| init(itemProvider: POSItemProvider) { | ||
| self.itemProvider = itemProvider | ||
| selectedItemPublisher = selectedItemSubject.eraseToAnyPublisher() | ||
| } | ||
|
|
||
| func select(_ item: POSItem) { | ||
| selectedItemSubject.send(item) | ||
| } | ||
|
|
||
| @MainActor | ||
| func populatePointOfSaleItems() async { | ||
| isSyncingItems = true | ||
| do { | ||
| items = try await itemProvider.providePointOfSaleItems() | ||
| } catch { | ||
| DDLogError("Error on load while fetching product data: \(error)") | ||
| } | ||
| isSyncingItems = false | ||
| } | ||
|
|
||
| @MainActor | ||
| func reload() async { | ||
| isSyncingItems = true | ||
| do { | ||
| let newItems = try await itemProvider.providePointOfSaleItems() | ||
| // Only clears in-memory items if the `do` block continues, otherwise we keep them in memory. | ||
| items.removeAll() | ||
| items = newItems | ||
| } catch { | ||
| DDLogError("Error on reload while updating product data: \(error)") | ||
| } | ||
| isSyncingItems = false | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
WooCommerce/WooCommerceTests/POS/ViewModels/ItemSelectorViewModelTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import XCTest | ||
| import Combine | ||
| @testable import WooCommerce | ||
| @testable import protocol Yosemite.POSItemProvider | ||
| @testable import protocol Yosemite.POSItem | ||
| @testable import struct Yosemite.POSProduct | ||
|
|
||
| final class ItemSelectorViewModelTests: XCTestCase { | ||
| private var itemProvider: POSItemProvider! | ||
| private var itemSelector: ItemSelectorViewModel! | ||
|
|
||
| private var cancellables: Set<AnyCancellable> = [] | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| itemProvider = MockPOSItemProvider() | ||
| itemSelector = ItemSelectorViewModel(itemProvider: itemProvider) | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| itemProvider = nil | ||
| itemSelector = nil | ||
| super.tearDown() | ||
| } | ||
|
|
||
| func test_isSyncingItems_is_true_when_populatePointOfSaleItems_is_invoked_then_switches_to_false_when_completed() async { | ||
| XCTAssertEqual(itemSelector.isSyncingItems, true, "Precondition") | ||
|
|
||
| // Given/When | ||
| await itemSelector.populatePointOfSaleItems() | ||
|
|
||
| // Then | ||
| XCTAssertEqual(itemSelector.isSyncingItems, false) | ||
| } | ||
|
|
||
| func test_isSyncingItems_is_true_when_reload_is_invoked_then_switches_to_false_when_completed() async { | ||
| XCTAssertEqual(itemSelector.isSyncingItems, true, "Precondition") | ||
|
|
||
| // Given/When | ||
| await itemSelector.reload() | ||
|
|
||
| // Then | ||
| XCTAssertEqual(itemSelector.isSyncingItems, false) | ||
| } | ||
|
|
||
| func test_itemSelector_when_select_item_then_sends_item_to_publisher() { | ||
| // Given | ||
| let item = Self.makeItem() | ||
| let expectation = XCTestExpectation(description: "Publisher should emit the selected item") | ||
|
|
||
| var receivedItem: POSItem? | ||
| itemSelector.selectedItemPublisher.sink { item in | ||
| receivedItem = item | ||
| expectation.fulfill() | ||
| } | ||
| .store(in: &cancellables) | ||
|
|
||
| // When | ||
| itemSelector.select(item) | ||
|
|
||
| // Then | ||
| XCTAssertEqual(receivedItem?.productID, item.productID) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| private extension ItemSelectorViewModelTests { | ||
| final class MockPOSItemProvider: POSItemProvider { | ||
| var items: [POSItem] = [] | ||
|
|
||
| func providePointOfSaleItems() async throws -> [Yosemite.POSItem] { | ||
| let item = makeItem() | ||
| return [item] | ||
| } | ||
| } | ||
|
|
||
| static func makeItem() -> POSItem { | ||
| return POSProduct(itemID: UUID(), | ||
| productID: 0, | ||
| name: "", | ||
| price: "", | ||
| formattedPrice: "", | ||
| itemCategories: [], | ||
| productImageSource: nil, | ||
| productType: .simple) | ||
| } | ||
| } |
Oops, something went wrong.