Remove unused function from formatters

[tomalec]

Changes proposed in this Pull Request:

Remove three unused functions that seem to be leftovers from the old implementation:

• trackChangeCartItemQuantity
• trackException
• trackEvent

Checks:

• Does your code follow the WordPress coding standards?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots:

Detailed test instructions:

1. Double-check that none of those functions is used in the code
2. Smoke test

Additional details:

Changelog entry

Dev - Remove unused functions from code.

[puntope]

✅ LGTM

For the trackChangeCartItemQuantity seems like change_cart_quantity is not supported anymore by GA?

[mikkamp]

Another one that doesn't seem to be used is add_shipping_info. Can we confirm if it was the intention to include this information during either begin_checkout or the purchase event?

[puntope]

Re- Cart item quantity #312

[tomalec]

@martynmjones Could you confirm regarding car quantities?

[martynmjones]

Another one that doesn't seem to be used is add_shipping_info. Can we confirm if it was the intention to include this information during either begin_checkout or the purchase event?

@martynmjones Could you confirm regarding car quantities?

We weren't previously tracking quantity changes or shipping info. Both those events had been added in the initial integration with Blocks in core but in testing neither were reliable and we didn't have an alternative for classic.

So as the extension was already not tracking those events we're safe to remove them. We can then look into alternatives at a later date if we decide we want to track the additional information.

[tomalec]

@martynmjones, and what about tracking shipping and add_shipping_info?
Previously we were tracking it in https://github.com/woocommerce/woocommerce-google-analytics-integration/pull/322/files#diff-aa47bb8c923774f3c31519cb78bd1ae693f025fe39846d2571eb13640b399a87L64-L74

Should we add checkout-set-shipping-address to blocks.js?

[martynmjones]

Sorry Tomek, I wasn't clear in my previous reply. The add_shipping_info event was only added in the core integration for Blocks and then copied over when we moved tracking for Blocks to the extension.

Before that it didn't exist in the extension and there was never an equivalent for classic pages so I think we're safe to remove it.