Fix: CC component not being mounted when also using legacy payment methods #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
first time contributor here. We had an issue with the recent versions of the plugin where the credit card field component would not be mounted on the checkout page. This problem only occurs when simultaneously legacy Stripe payment methods are also active in the shop (GiroPay via Stripe Sources in our case). I tracked the issue down to the
woocommerce_stripescript being mounted too early inWC_Stripe_Payment_Gateway::payment_scripts().This change allows us to finally use the latest version of the plugin. Previously we were not able to update since version 8.0.1. Hope you also find this helpful!