-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release branch/2.5.2 #291
Merged
Merged
Release branch/2.5.2 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into release-branch/2.5.2
… into release-branch/2.5.2
…setting' into release-branch/2.5.2
…release-branch/2.5.2
…ease-branch/2.5.2
… into release-branch/2.5.2
…d-on-gravity-add-on' into release-branch/2.5.2
…release-branch/2.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes:
#252, #257, #256, #263, #207
How to test the changes in this Pull Request:
for Error when using a non standrad decimal amount for a currency #252
3. Set 4 decimals for EUR or USD
4. Go to the site and add the product to the cart,
5. go to the cart and open the console of the browser,
6. no related console error should be displayed, the decimals should be truncated to the default for each currency.
for chargeAmount.Amount is invalid when changing currency after selecting other shipping address #257
7. Setup Amazon with Price based on country
8. Add product to cart and use the Express Checkout
9. Select other shipping address that changes the amount (like JPY)
10. Try to place order.
11. It should remove the decimals.
for Not hiding the -OR- on Minicart when selecting "Enable hide button mode" #256
12. when selecting "Enable hide button mode "- OR -" string should be hidden on minicart
for Change Payment Method for a Subscription Paid with another Payment Method (like Stripe or PayPal) #263
13. Purchase a subscription with PayPal or Stripe.
14. Go to Subscription and click on "Change Payment Method"
15. Select "Amazon" or click on the Amazon Pay Express button,
16. Payment Method changed without a problem.
for Express Checkout on Product page not getting the values of the variations created by WooCommerce Product Add-Ons and Gravity Forms Product Add-ons #207:
17. Install and activate WooCommerce Product Add-Ons or Gravity Forms Product Add-ons
18. Set up some variables that add some value to the product
19. With the user go to the product page and select the variable that adds value to the price
20. Click on the Express checkout of Amazon Pay and log in to the account
21. The thank you page doesn't show the variable that was added by user
Other information:
Changelog entry