Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WooPayments payment gateway #6

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Conversation

chrismccluskey
Copy link
Collaborator

@chrismccluskey chrismccluskey commented Nov 13, 2024

Changes proposed in this Pull Request

  • Adds support for the WooPayments payment gateway plugin.

Testing instructions

  • Automated tests are included.

Mentions 507-gh-automattic/gold

@chrismccluskey chrismccluskey marked this pull request as ready for review November 14, 2024 00:06
Copy link
Collaborator

@millerf millerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apart from the small leftover "echo".

add_filter(
'sift_for_woocommerce_woocommerce_payments_charge_details_from_order',
function ( $value, \WC_Order $order ) {
echo '[getting charge details from order]';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test echo leftovers

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I'll remove that.

Copy link

Code Coverage

Package Line Rate Complexity Health
inc/abuse-decisions-actions.php 0% 22
inc/abuse-decisions.php 0% 12
inc/payment-gateway.php 100% 5
inc/payment-gateways/index.php 0% 0
inc/payment-gateways/lib/stripe.php 77% 61
inc/payment-gateways/load.php 0% 0
inc/payment-gateways/paypal.php 0% 0
inc/payment-gateways/stripe.php 23% 17
inc/payment-gateways/transact.php 100% 0
inc/payment-gateways/woocommerce-payments.php 100% 0
inc/payment-method.php 97% 31
inc/payment-type.php 83% 3
inc/rest-api-webhooks.php 0% 5
inc/sift-object-validator.php 89% 130
inc/sift-order.php 100% 4
inc/sift-property.php 100% 3
inc/tracking-js.php 0% 4
inc/verification-status.php 50% 3
inc/wc-settings-tab.php 0% 14
inc/woocommerce-actions.php 70% 91
index.php 0% 0
sift-for-woocommerce.php 0% 9
Summary 63% (913 / 1459) 414

@chrismccluskey chrismccluskey merged commit 4da08e0 into trunk Nov 14, 2024
12 checks passed
@chrismccluskey chrismccluskey deleted the add/woopayments-gateway branch November 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants