Adding missing gap between page intro and the banner. #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message-dimke
added
type: bug
|
Can we do this PR against the V5 integration branch so we will not need to do any rebases? |
github-actions
bot
added
the
changelog: fix
message-dimke
changed the base branch from
develop
to
pinterest-v5-integration-branch
|
Hey, @budzanowski ! It is done! |
message-dimke
merged commit 27efdd2
into
pinterest-v5-integration-branch
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Puts back the margin removed by Pinterest css rules.
Closes #890
Screenshots:
Detailed test instructions:
developbranch, check the disconnected extension's Home screen.fix/no-margin-above-the-bannerbranch and build its sources.nvm use && nom run build.Changelog entry