Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token exchange endpoint #841

Merged

Conversation

budzanowski
Copy link
Collaborator

Changes proposed in this Pull Request:

This introduces a class that is able to exchange the V3 token for a V5 token.

Closes #840 .

This adds the API method for the token exchange procedure.
A separate class has been added because we need to ping the v3 endpoint
so we need the constant to point to V3. We don't want to use the Base class bc it will be removed.
Besides the endpoint, this will also be the location for the update procedure method.

Detailed test instructions:

No testing for now. This will be testable when the update procedure will be implemented.

Additional details:

This is a part of the #739

Changelog entry

No changelog required.

@budzanowski budzanowski added the changelog: none Skip changelog entry for this PR label Nov 6, 2023
@budzanowski budzanowski self-assigned this Nov 6, 2023
@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels Nov 6, 2023
@budzanowski budzanowski changed the title Add/token exchange endpoint Add token exchange endpoint Nov 6, 2023
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you, @budzanowski

@budzanowski budzanowski merged commit d41ee8e into pinterest-v5-integration-branch Nov 8, 2023
8 checks passed
@budzanowski budzanowski deleted the add/token-exchange-endpoint branch November 8, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. changelog: none Skip changelog entry for this PR type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants