-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinterest Conversions API #787
Merged
message-dimke
merged 33 commits into
pinterest-v5-integration-branch
from
add/pinterest-conversions
Aug 30, 2023
Merged
Pinterest Conversions API #787
message-dimke
merged 33 commits into
pinterest-v5-integration-branch
from
add/pinterest-conversions
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: add
A new feature, function, or functionality was added.
type: enhancement
The issue is a request for an enhancement.
labels
Jun 30, 2023
message-dimke
commented
Jul 10, 2023
…ag and conversions api handlers.
…alls to new classes. Add new tracker initialisation.
budzanowski
requested changes
Aug 15, 2023
Co-authored-by: Bartosz Budzanowski <[email protected]>
…ts on data class methods.
…vent to be rendered during the next page load.
… xml generator unit test.
Looks very nice after all of the refactors. Great job. |
budzanowski
approved these changes
Aug 30, 2023
We can merge! |
message-dimke
merged commit Aug 30, 2023
ff326f6
into
pinterest-v5-integration-branch
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: add
A new feature, function, or functionality was added.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #771 .
Adds Conversions API implementation as well as Pinterest Tag implementation refactoring. Now we have a general Tracking class which hooks into events of interest and had trackers attacked to handle action accordingly.
e.g. Tracking has two tracker implementations: Tag and Conversions. Tracking class hooks into
add to cart
event and when action is fired it notifies trackers about the event so the last could perform their corresponding actions.Conversions API events are logged under
pinterest-for-woocommerce-conversions-<date>
log files so the user could see what was logged.Pinterest has events log which shows events receive through Tag and Conversion APIs. It is located under Ads -> Conversions
Unfortunately I was not able to find where Pinterest stores any event details we report. Could be it is not yet implemented or something.
Detailed test instructions:
add/pinterest-conversions
branchAdditional details:
Changelog entry