-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making integration_data
data not mandatory.
#1077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction. - Redoing how 'is connected' user is identified. - Adjusting unit tests to the new 'is connected' behaviour.
github-actions
bot
added
the
changelog: update
Big changes to something that wasn't broken.
label
Oct 22, 2024
…ep where they belong; - Introducing Commerce Integration controller class; - Adjusting unit tests; - Adding commerce integration retry action registration; - Adding commerce integration retry actions cleanup on disconnect;
… create the integration if the one is missing.
budzanowski
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…be changed in the future without paying attention to set a proper time frame for it.
…ration-sync Synchronising Commerce Integration `partner_metadata` weekly.
…tion-retry Retrying Commerce Integration Creation on Falure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Integration data appeared not mandatory for the extension to function. However, we were using it to identify if the user connected status. Since the Pinterest Commerce Integration request may fail, we do not want the extension to rely on its presence.
Detailed test instructions:
APIV5::create_commerce_integration
call fail.pinterest-for-woocommerce/src/API/APIV5.php
Lines 407 to 413 in f48b082
Changelog entry