Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing feed #1067

Merged
merged 22 commits into from
Sep 24, 2024
Merged

Reuse existing feed #1067

merged 22 commits into from
Sep 24, 2024

Conversation

message-dimke
Copy link
Contributor

@message-dimke message-dimke commented Sep 16, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Closes #1060

The PR aims to fix multiple things related to the feed deletion issue.

  • The update procedure will remove duplicates of the Feed Deletion Failure notice.
  • Feed deletion failure notice also got an updated text.
  • Existing feeds to be fetched from Pinterest and reactivated, if any.
  • Removing the condition to auto-disconnect the plugin in case of 403 Pinterest API error response (Pinterest returns 403 when an unapproved merchant can not delete their feed, which is not an access token-related issue, and we do not need to disconnect in this case).

Changelog entry

Fix - Feed Deletion Failure notice duplicates removal.
Fix - Reuse existing feed, if any.
Fix - 403 Pinterest API error response is not the reason to auto-disconnect.
Dev - Tests suits update.

@message-dimke message-dimke self-assigned this Sep 16, 2024
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Sep 16, 2024
@message-dimke
- Fixing phpcs.
c8266c9 
- Fixing error with a test.
@message-dimke
Adding exception handling.
c63ca33
@message-dimke
Fixing feeds unit tests.
e1a5e74
@message-dimke
Unit tests refinement: tear down each test with filters cleanup.
6f3cf46
@message-dimke
Adjusting feed registration logic. Unregister the feed if product syn…
a0f59bb 
…c settings has changed and not always if the value of the option casts to FALSE.
@message-dimke
Code styling adjustments.
9db1b32
@message-dimke
Fix the test expectations based on system temp directory and uploads …
b51881a 
…path with url.
@message-dimke
Fixing code styling error.
316c7df
@message-dimke
Expanding local feed configuration tests.
51dbab0
@message-dimke
Handle case when remote feed does not have a unique tail in the locat…
832585d 
…ion for the file.
@message-dimke
Add note once only.
6552546
@message-dimke
Adding feed deletion failed notice test.
6bfc17f
@message-dimke
Fixing feed deletion failure note duplication.
46e326b
@message-dimke
Fixing the multiple feed deletion failed notices deletion test.
3d3179a
@message-dimke
Adding feed deletion failure notices cleanup on plugin update.
3cb8419
@message-dimke
Fixing wrong update function call.
9252f79
@message-dimke message-dimke marked this pull request as ready for review September 19, 2024 15:20
@message-dimke message-dimke requested a review from a team September 19, 2024 15:20
budzanowski
budzanowski reviewed Sep 23, 2024
View reviewed changes
src/Feeds.php Outdated Show resolved Hide resolved
budzanowski
budzanowski reviewed Sep 23, 2024
View reviewed changes
src/Feeds.php Outdated Show resolved Hide resolved
budzanowski
budzanowski approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@budzanowski budzanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments, a nitpicks, looks good. Approving.

message-dimke and others added 3 commits September 24, 2024 09:24
@message-dimke @budzanowski
Update the comment message
5ee41e1 
Co-authored-by: Bartosz Budzanowski <[email protected]>
@message-dimke
- Fixing operator precedence bug.
fd66d14 
- Refactoring to early exit methodology.
@message-dimke
PHP code styling fixes.
f66b2dd
@message-dimke message-dimke merged commit 0a8159b into develop Sep 24, 2024
4 checks passed
@message-dimke message-dimke deleted the fix/reuse-existing-feed branch September 24, 2024 06:46
@message-dimke message-dimke mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budzanowski budzanowski budzanowski approved these changes

Assignees

@message-dimke message-dimke

Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

25 Feed Deletion Failed messages
2 participants
@message-dimke @budzanowski