Fixing Pinterest Save button positioning for Twenty Twenty-Four theme. #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with its absolute positioning would stay above the product card.
github-actions
bot
added
changelog: fix
ecgan
requested changes
Aug 23, 2024
assets/source/sass/frontend/pinterest-for-woocommerce-pins.scss
Outdated
Show resolved
Hide resolved
|
@message-dimke , I was testing around and I noticed that the Pinterest "Save" button does not show up in the product page with Twenty Twenty-Four theme. Screenshot of product image in product page:
Screenshot of related products in product page - note that for this one, it is using
Maybe you could consider opening separate issues / PRs to fix them. |
Fixing class name typo and adding wp-block-post back to support related products section. Co-authored-by: Gan Eng Chin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #1054.
Pinterest Save button has CSS absolute positioning when the product card has no CSS relative position rule on it which makes Pinterest Save button align relatively to the document, instead of a product card element.
Screenshots:
Detailed test instructions:
Changelog entry