Add regenerator-runtime as script dependency (quick fix for WordPress 6.6 breaking change) #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix for a breaking change in WordPress 6.6.
ecgan
added
category: compatibility
changelog: fix
message-dimke
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
I confirm it works with WP 6.6 RC2 now! Thank you, @ecgan !
layoutd
pushed a commit
that referenced
this pull request
Jul 23, 2024
…runtime Add regenerator-runtime as script dependency (quick fix for WordPress 6.6 breaking change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #1031. For the cause of issue and related readings on
regenerator-runtime, see #1031 (comment).In this PR, we add
regenerator-runtimeas a script dependency. This is a quick fix for a breaking change in WordPress 6.6.I believe we may not need this quick fix in the future when we update the
@wordpress/*packages and rely on Dependency Extraction (without bundling the packages).Detailed test instructions:
/wp-admin/admin.php?page=wc-admin&path=%2Fpinterest%2Flanding. You should see the landing page nicely. There should be no console error./wp-admin/admin.php?page=wc-admin&path=%2Fpinterest%2Flanding. You should see the landing page nicely. There should be no console error.