-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CAPI tracker by Pinterest request. #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do it via separate setting for CAPI. We should make the capi tracker option false. No UI for it would mean that we don't have to do anything else for now.
During the testing you just switch the CAPI tracker option to true and you can run the tests. We don't want to delete them because we will have to reintroduce them back very soon.
…r status. Forcing it to false not to enable the tracker per Pinterest requirement. Adding unit tests to cover trackers initialization logic (CAPI can only be initialized if Tag is also ON, no CAPI tracker alone is possible).
When connecting to Pinterest, Pinterest replies back with a set of features and their corresponding statuses. The set looks like this:
The three flags above indicate what was chosen during the onboarding wizard (a Pinterest-hosted wizard). For example, choosing to sync catalog will send the The problem is tracking. Pinterest has a single wizard screen for tracking and a single yes/no button that turns ON/OFF both Introducing the new Does it make sense? |
For now this is good enough. We can change it later when they will have separate consents. |
Looks good. Do we need to add plugin update procedure that sets CAPI tracking to false explicitly? Or not set will default to false? |
If the setting is empty or there is no such setting, it will resolve to pinterest-for-woocommerce/class-pinterest-for-woocommerce.php Lines 557 to 562 in c85534a
If I read it correct =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lets do it. Please remember that this should be a GitHub only release.
Changes proposed in this Pull Request:
Disabling Conversion API tracker according to some temporary legal aspects from Pinterest.
How to test.
pinterest_for_woocommerce
option insidewp_options
database table.s:22:"track_conversions_capi";b:0;
serialized data.ON
, we force itOFF
into options.e.g.
s:17:"track_conversions";b:1;s:22:"track_conversions_capi";b:0;
: Pinterest Tag onON
, but Conversions API isOFF
.Changelog entry