Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Undefined array key "path" warning thrown by DomainVerification.php #1023

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rawdreeg
Copy link
Contributor

Changes proposed in this Pull Request:

Related to #903.

Closes #1022.

I encountered the following while testing for WC 9.0 compat.
PHP Warning: Undefined array key "path" in /srv/htdocs/wp-content/plugins/pinterest-for-woocommerce/src/API/DomainVerification.php on line 66. This PR fixes this.

Detailed test instructions:

  1. Install on a store with PHP 8.3.
  2. Enable WP_DEBUG, WP_DEBUG_LOGGING.
  3. Go through smoke testing steps: Wiki: Smoke Tests ()
  4. Check the logs for warnings or notices.
  5. (See issues for exact notices that could be present)

Changelog entry

Fix - Undefined array key "path" warning thrown by DomainVerification.php

@rawdreeg rawdreeg self-assigned this Jun 13, 2024
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Jun 13, 2024
@rawdreeg rawdreeg requested a review from a team June 13, 2024 08:00
Copy link
Collaborator

@budzanowski budzanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume that the path is useful for cases when the installation lives in a subdomain.

@rawdreeg rawdreeg merged commit b3e1d6e into develop Jun 13, 2024
5 checks passed
@rawdreeg rawdreeg deleted the fix/1022-undefined-key-warning branch June 13, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.3 Warning: Undefined array key "path
2 participants