Avoid running malicious inputs as shell commands in Custom GitHub actions and relate workflows #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR avoids running malicious inputs as shell commands in the GitHub Actions.
Although the most input values are entered by devs who have access to their repo, which means it's almost unlikely to be vulnerable to such attacks, it would be better to fix it.
Ref: https://securitylab.github.com/research/github-actions-untrusted-input/
Detailed test instructions:
📌 Workflows for managing test build
📌
automerge-released-trunk
actionI don't prepare a test for this as it uses the same fix as woocommerce/google-listings-and-ads#2394
📌
eslint-annotation
andstylelint-annotation
actionseslint-annotation
andstylelint-annotation
actions📌
prepare-extension-release
action📌
merge-trunk-develop-pr
actions📌
prepare-node
andprepare-php
actionsprepare-node
action.prepare-php
action uses the same fix so I believe it should work as well.📌
run-qit-annotate
actionrun-qit-annotate
action of this PR