-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor & fix undesired exceptions in AS Jobs #2666
base: add/support-core-gtin-field
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add/support-core-gtin-field #2666 +/- ##
===============================================================
+ Coverage 64.7% 64.9% +0.2%
- Complexity 4638 4667 +29
===============================================================
Files 798 478 -320
Lines 24536 19517 -5019
Branches 1242 0 -1242
===============================================================
- Hits 15875 12674 -3201
+ Misses 8488 6843 -1645
+ Partials 173 0 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param string $gtin | ||
* @return string | ||
*/ | ||
protected function error_gtin_invalid( \WC_Product $product, string $gtin ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, and we don't seem to be consistent. But in most cases in the code we add use WC_Product
to be able to remove the \
. But I'm not attached to either method so both are fine.
|
||
/** | ||
* Add some info in the debug console. | ||
* Add --debug to see this kind of logs in WP CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nitpick about the wording (this should be plural):
* Add --debug to see this kind of logs in WP CLI | |
* Add --debug to see these logs in WP CLI |
Changes proposed in this Pull Request:
Closes part of #2617
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry