Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Streamline the onboarding flow #2631

Open
wants to merge 84 commits into
base: develop
Choose a base branch
from

Conversation

joemcgill and others added 20 commits August 26, 2024 15:24
…ithub.com:woocommerce/google-listings-and-ads into update/2490-hide-tax-rate-selection-ui-onboarding
…nch-checklist-items

Remove pre launch checklist items
…nch-checklist

2492: Remove PreLaunchChecklist component
…election-ui-onboarding

Hide Tax UI during onboarding & keep in edit campaign
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (1c6a902) to head (a2a1e84).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
.../free-listings/setup-free-listings/form-content.js 0.0% 1 Missing and 1 partial ⚠️
...c/components/stepper/step-content-actions/index.js 33.3% 1 Missing and 1 partial ⚠️
...ponents/free-listings/setup-free-listings/index.js 50.0% 1 Missing ⚠️
.../src/components/paid-ads/asset-group/faqs-panel.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2631      +/-   ##
============================================
- Coverage       65.3%   62.7%    -2.6%     
============================================
  Files            474     319     -155     
  Lines          17893    5063   -12830     
  Branches           0    1233    +1233     
============================================
- Hits           11685    3173    -8512     
+ Misses          6208    1716    -4492     
- Partials           0     174     +174     
Flag Coverage Δ
js-unit-tests 62.7% <28.0%> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...choose-audience-section/choose-audience-section.js 33.3% <ø> (ø)
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/paid-ads/ads-campaign.js 0.0% <ø> (ø)
js/src/components/paid-ads/faqs-panel.js 66.7% <100.0%> (ø)
...rc/components/stepper/step-content-footer/index.js 50.0% <100.0%> (ø)
js/src/components/vertical-gap-layout/index.js 100.0% <ø> (ø)
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/actions.js 7.9% <ø> (ø)
js/src/data/reducer.js 83.5% <ø> (ø)
js/src/data/resolvers.js 7.6% <ø> (ø)
... and 7 more

... and 775 files with indirect coverage changes

@joemcgill joemcgill self-assigned this Sep 30, 2024
@joemcgill joemcgill marked this pull request as ready for review October 25, 2024 19:51
@joemcgill joemcgill changed the title Feature/2458 streamline onboarding Feature: Streamline the onboarding flow Oct 25, 2024
@mikkamp
Copy link
Contributor

mikkamp commented Oct 29, 2024

Just wanted to clarify that the failing unit test has already been resolved in PR #2626

We can ignore that here (no need to merge the latest changes into this branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding Improvements Overview
6 participants