Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

eason9487 · 2024-08-23T11:28:30Z

Changes proposed in this Pull Request:

This PR wraps up PRs:

💡 All code changes have been reviewed and tested in the respective PRs. Therefore, this PR should not require extra rounds of code reviews.

Changelog entry

Ref: https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Fixed by running `npm run lint:js -- --fix`.

…e` rule.

…oesn't support `package.json.exports`.

…merce/currency`.

…dependencies of '@automattic/components'.

…@woocommerce/*`.

Migration includes: - Invoke `userEvent.setup()` in the test itself and before the component is rendered. - Adding `async` and `await` as all APIs are asynchronous. - No need to be wrapped in `act`. - Replace the simulation of pressing buttons with the `keyboard` API. - `clear()` is changed to only support editable elements only.

…ssertions` rule.

… `alt` is an empty string.

… be rendered.

…rEvent`.

… calling `console.error()`.

…y WordPress 6.4 to replace `position`.

…it returns the same key regardless of the query keys' order.

…onCodeControl>`. Ref: #1098

… `<CampaignAssetsForm>`.

Address: #2544 (comment)

Ref: #2544 (comment)

…t pair with Node.js 20. Address: #2517 (comment)

…lint rule. Ref: #2517 (comment)

Upgrade to use Node.js 20 and bump npm dependencies

…20-and-compatible-wp-wc Migrate jest tests to use Node.js 20 and make components compatible with upgraded packages

codecov · 2024-08-23T11:33:28Z

Codecov Report

Attention: Patch coverage is 76.92308% with 24 lines in your changes missing coverage. Please review.

Project coverage is 62.8%. Comparing base (ec86226) to head (e46bd2e).
Report is 43 commits behind head on develop.

Files	Patch %	Lines
js/src/components/app-tooltip/index.js	50.0%	3 Missing and 1 partial ⚠️
js/src/components/tree-select-control/index.js	78.6%	3 Missing ⚠️
...ute-mapping/attribute-mapping-delete-rule-modal.js	0.0%	1 Missing and 1 partial ⚠️
.../attribute-mapping/attribute-mapping-rule-modal.js	50.0%	1 Missing and 1 partial ⚠️
js/src/components/tree-select-control/control.js	0.0%	1 Missing and 1 partial ⚠️
js/src/data/actions.js	50.0%	2 Missing ⚠️
...roduct-feed/review-request/review-request-modal.js	50.0%	2 Missing ⚠️
js/src/components/paid-ads/campaign-assets-form.js	66.7%	1 Missing ⚠️
js/src/components/tree-select-control/checkbox.js	50.0%	1 Missing ⚠️
js/src/data/utils.js	95.8%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##             develop   #2562      +/-   ##
============================================
- Coverage       65.0%   62.8%    -2.3%     
============================================
  Files            475     321     -154     
  Lines          17900    5085   -12815     
  Branches           0    1234    +1234     
============================================
- Hits           11640    3191    -8449     
+ Misses          6260    1721    -4539     
- Partials           0     173     +173

Flag	Coverage Δ
js-unit-tests	`62.8% <76.9%> (?)`
php-unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ion/phone-number-card/verification-code-control.js	`98.2% <100.0%> (ø)`
...ponents/free-listings/setup-free-listings/index.js	`6.8% <ø> (ø)`
...components/paid-ads/asset-group/images-selector.js	`100.0% <ø> (ø)`
js/src/components/tree-select-control/tags.js	`92.9% <100.0%> (ø)`
...e-card/program-toggle/pause-program-modal/index.js	`14.3% <ø> (ø)`
...emove-program-button/remove-program-modal/index.js	`7.1% <ø> (ø)`
js/src/gtag-events/utils.js	`96.2% <100.0%> (ø)`
js/src/hooks/useMCIssuesTotals.js	`100.0% <100.0%> (ø)`
js/src/product-feed/issues-table-card/index.js	`100.0% <100.0%> (ø)`
.../product-feed-table-card/edit-visibility-action.js	`52.9% <ø> (ø)`
... and 19 more

... and 767 files with indirect coverage changes

eason9487 added 30 commits August 16, 2024 17:20

Bump npm dependencies and upgrade to use Node.js v20.

8d6d98b

Fix the build config of Fast Refresh mode.

b8b1129

Address Sass deprecation warnings.

8dc4a94

Ref: https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Turn off the eslint rule react/react-in-jsx-scope.

ddc2b96

Turn off the eslint rule jsdoc/check-line-alignment.

f6997f7

Turn off the eslint rule import/no-named-as-default.

23536a4

Resolve eslint errors for the @wordpress/i18n-text-domain rule.

cdd9aab

Resolve eslint errors that can be automatically fixed.

c41ef64

Fixed by running `npm run lint:js -- --fix`.

Resolve eslint errors for the jsdoc/no-undefined-types rule.

67ef0e2

Resolve eslint errors for the import/no-unresolved rule.

c4db2a3

Resolve eslint errors for the no-redeclare rule.

6997b6f

Resolve eslint errors for the jsdoc/require-yields-check rule.

47d1f9f

Resolve eslint errors for the `@typescript-eslint/no-use-before-defin…

9886344

…e` rule.

Resolve eslint errors for the jsdoc/tag-lines rule.

fccc0cd

Jest: Fix that [email protected] doesn't provide the CommonJS build.

6fb9a6c

Jest: Force 'uuid' to resolve with the CommonJS entry point as jest d…

d5de474

…oesn't support `package.json.exports`.

Jest: Fix @woocommerce/components still using incompatible `@woocom…

964e769

…merce/currency`.

Jest: Ignore that 'qrcode.react' module is incorrectly listed in dev …

d8b3d7a

…dependencies of '@automattic/components'.

Jest: Fix the React versioning conflicts between @wordpress/* and `…

76c1efa

…@woocommerce/*`.

Jest: Update timer mocks to deprecate the timers option.

e9cbf6a

Resolve eslint errors for the `testing-library/no-wait-for-multiple-a…

38d4563

…ssertions` rule.

Resolve eslint errors for the testing-library/no-unnecessary-act rule.

b634d9e

Jest: Prevent form submission during testing.

def9cb0

Jest: The ARIA role of <img> is considered as presentation if its…

45f90a7

… `alt` is an empty string.

Jest: Prevent the <Dashboard> tests from calling window.fetch.

d5e5324

Jest: Adjust <Stepper> related tests to wait for stepper content to…

ad1daac

… be rendered.

Jest: Update snapshots to reflect the format changes.

b7c6eca

Jest: Fix CampaignNameCell tests by replacing fireEvent with `use…

a89e0b2

…rEvent`.

Jest: Ignore the deprecation warnings of defaultProps from React by…

0686dc9

… calling `console.error()`.

eason9487 added 12 commits August 19, 2024 18:20

Jest: Remove the structuredClone polyfill no longer needed.

9df6ee1

Make <AppTooltip> compatible with the placement prop introduced b…

757b5c9

…y WordPress 6.4 to replace `position`.

Rewrite the replacer of JSON.stringify in getReportKey to ensure …

940649d

…it returns the same key regardless of the query keys' order.

Replace deprecated event.keyCode with event.code for `<Verificati…

8554c2d

…onCodeControl>`. Ref: #1098

Avoid accidentally using the event object to reset the asset group in…

e2b305f

… `<CampaignAssetsForm>`.

Add code document for the replacer function in js/src/data/utils.js.

69fc1b4

Address: #2544 (comment)

Add a more detailed description for the mock isWpVersion function.

c9a259f

Ref: #2544 (comment)

Allow npm ^9 because dependabot is using an npm version that doesn'…

b2a3d13

…t pair with Node.js 20. Address: #2517 (comment)

Add a more detailed code comment to the jsdoc/no-undefined-types es…

c76514b

…lint rule. Ref: #2517 (comment)

Merge pull request #2517 from woocommerce/dev/2002-use-nodejs-20

7316de3

Upgrade to use Node.js 20 and bump npm dependencies

Merge pull request #2544 from woocommerce/tweak/2002-jest-for-nodejs-…

b22d9c6

…20-and-compatible-wp-wc Migrate jest tests to use Node.js 20 and make components compatible with upgraded packages

Merge branch 'develop' into dev/use-nodejs-20

e46bd2e

eason9487 self-assigned this Aug 23, 2024

github-actions bot added the changelog: dev Developer-facing only change. label Aug 23, 2024

eason9487 added changelog: none Skip changelog entry for this PR and removed changelog: dev Developer-facing only change. labels Aug 23, 2024

eason9487 merged commit 981f1a8 into develop Aug 23, 2024
10 checks passed

eason9487 deleted the dev/use-nodejs-20 branch August 23, 2024 11:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

eason9487 commented Aug 23, 2024

codecov bot commented Aug 23, 2024 •

edited

Loading

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

Conversation

eason9487 commented Aug 23, 2024

Changes proposed in this Pull Request:

Changelog entry

codecov bot commented Aug 23, 2024 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2024 •

edited

Loading