Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2499: Add coupon banner #2558

Merged

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Aug 22, 2024

Changes proposed in this Pull Request:

Closes #2499

Replace this with a good description of your changes & reasoning.

Screenshots:

image

Detailed test instructions:

  1. Go through the onboarding flow.
  2. When connecting accounts on the first step, create a new Google Ads account from the UI. This is the only way for the user to be "eligible" to see the banner.
  3. On the last step of the onboarding process, the banner should be visible as per the screenshot in the ticket description .
  4. The previous text for the $500 credit that was below "Set a daily budget" should no longer appear.

Additional details:

Changelog entry

Tweak - Change to use a banner to present the ad credit offer during onboarding.

@asvinb asvinb requested a review from joemcgill August 22, 2024 11:53
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (5d5ed13) to head (9a612d3).
Report is 10 commits behind head on feature/2459-campaign-creation-flow.

Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                         @@
##           feature/2459-campaign-creation-flow   #2558   +/-   ##
===================================================================
  Coverage                                 63.8%   63.8%           
===================================================================
  Files                                      326     326           
  Lines                                     5089    5089           
  Branches                                  1231    1231           
===================================================================
  Hits                                      3245    3245           
  Misses                                    1676    1676           
  Partials                                   168     168           
Flag Coverage Δ
js-unit-tests 63.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joemcgill joemcgill changed the base branch from develop to feature/2459-campaign-creation-flow August 22, 2024 14:29
@ankitrox ankitrox self-requested a review August 23, 2024 10:55
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js Outdated Show resolved Hide resolved
tests/e2e/utils/mock-requests.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all. I've left some feedback inline, but the main issue is that this isn't displaying on the fourth step when testing locally.

I'll get some clarity about whether the useFreeAdCredit() hook needs to be adjusted, but if so, we'll handle that as a separate task. For now, the new banner should display any time the current "Claim $500 in ads credit..." text was previously shown and that text should be removed.

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected. I left a comment inline about needing to address the requirements for when this should be displayed in a follow-up task.

@joemcgill joemcgill dismissed ankitrox’s stale review August 27, 2024 21:19

No longer applies

@ankitguptaindia
Copy link
Member

ankitguptaindia commented Aug 28, 2024

QA/Test Report-

Testing Environment -

  • WordPress: 6.6.1
  • Theme active on store: Storefront Version: 4.6.0 / Twenty Twenty-Four Version: 1.2
  • WooCommerce - Version 9.2.3
  • PHP: 8.3
  • Web Server: Nginx
  • Browser: Chrome - Version 127
  • OS: macOS Sonoma 14.6.1

Test Results - Ad coupon banner appears as described in the description. ✅

Functional Demo / Screencast -

image

@eason9487 eason9487 added changelog: add A new feature, function, or functionality was added. changelog: tweak Small change, that isn't actually very important. and removed changelog: add A new feature, function, or functionality was added. labels Sep 4, 2024
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. There are two issues need to be resolved.

@asvinb
Copy link
Collaborator Author

asvinb commented Sep 5, 2024

@joemcgill I made a few updates following @eason9487 's comments. Can you kindly check please?

@joemcgill
Copy link
Collaborator

@eason9487 I've opened #2599 to clarify and address the requirements for the useFreeAdCredit() hook.

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the further update! LGTM.

@joemcgill joemcgill merged commit 188983d into feature/2459-campaign-creation-flow Sep 22, 2024
8 checks passed
@joemcgill joemcgill deleted the feature/2499-banner-coupon branch September 22, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Campaign Creation: Add coupon banner to the top of the page
5 participants