Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.5 #2347

Merged
merged 16 commits into from
Apr 4, 2024
Merged

Release 2.6.5 #2347

merged 16 commits into from
Apr 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 4, 2024

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.6.5
    git checkout release/2.6.5
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.6.5  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.6.5
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.6.5   --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.6.5
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.6.5, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.9%. Comparing base (88782dc) to head (ae233b2).

❗ Current head ae233b2 differs from pull request most recent head 2004bf6. Consider uploading reports for the commit 2004bf6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2347     +/-   ##
=========================================
+ Coverage     62.7%   62.9%   +0.1%     
  Complexity    4252    4252             
=========================================
  Files          751     751             
  Lines        21789   21783      -6     
  Branches       542     542             
=========================================
+ Hits         13672   13700     +28     
+ Misses        7661    7627     -34     
  Partials       456     456             
Flag Coverage Δ
js-unit-tests 55.2% <ø> (ø)
php-unit-tests 64.5% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)
src/Notes/ReviewAfterClicks.php 100.0% <100.0%> (+100.0%) ⬆️
src/Notes/ReviewAfterConversions.php 100.0% <100.0%> (ø)

@martynmjones
Copy link
Contributor

[Dev] Developer-facing changes 🧑‍💻

[Tweak] Tweaked 🔧

@martynmjones martynmjones merged commit cfe669b into trunk Apr 4, 2024
@martynmjones martynmjones deleted the release/2.6.5 branch April 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants