Fix the compatibility issue in starting E2E test environment due to the default charset change in MariaDB v11.3.1 #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he default charset change in MariaDB v11.3.1. Ref: - https://jira.mariadb.org/browse/MDEV-32975 - WordPress/gutenberg#59237
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2272 +/- ##
============================================
- Coverage 61.5% 54.0% -7.5%
============================================
Files 748 293 -455
Lines 21540 3715 -17825
Branches 532 532
============================================
- Hits 13246 2006 -11240
+ Misses 7843 1258 -6585
Partials 451 451
Flags with carried forward coverage won't be shown. Click here to find out more. |
martynmjones
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Hey @eason9487, thanks for the fix!
Locally the environment setup correctly and all tests pass so LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
MariaDB v11.3.1 introduced an issue that breaks backward compatibility for many PHP DB clients. It also affects the starting of E2E test env in this repo.
To fix it, this PR updates
@wordpress/envto 9.4.0 to use the LTS version of MariaDB rather than the (default) latest version.Screenshots:
📷 Before
📷 After
Detailed test instructions:
📌 Check the results on GitHub Actions
📌 Local test
npm run wp-env destroyfirst to ensure the incompatible database will be recreated.npm run wp-env:upto see if the E2E test env can be started without errors.npm run test:e2eto see if E2E tests can be run normally.npm run wp-env:downto see if E2E test env can be stopped correctly.Changelog entry