Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.14 #2187

Merged
merged 24 commits into from
Dec 18, 2023
Merged

Release 2.5.14 #2187

merged 24 commits into from
Dec 18, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 18, 2023

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.5.14
    git checkout release/2.5.14
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.5.14  --wc_tested=8.4 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.14
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.5.14  --wc_tested=8.4  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.14
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.5.14, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

puntope and others added 20 commits November 30, 2023 20:12
Release 2.5.13 - Merge `trunk` to `develop`
…ing-setup-ads

Add (budget and audiences) tracking for Onboarding completed with Ads
…he page to load to proceed with assertions.
…oogle-ads-connection

Change to require Google Ads connection during the onboarding
Include PHP 8.3 in tested versions for PHPunit
…rrect-in-purchase-event

Fix item price in purchase event
@puntope puntope self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2187 (80ab4d7) into trunk (90d4872) will increase coverage by 1.2%.
The diff coverage is 0.0%.

❗ Current head 80ab4d7 differs from pull request most recent head fa34677. Consider uploading reports for the commit fa34677 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2187     +/-   ##
=========================================
+ Coverage     58.2%   59.4%   +1.2%     
  Complexity    4127    4127             
=========================================
  Files          453     453             
  Lines        17691   16478   -1213     
=========================================
- Hits         10300    9788    -512     
+ Misses        7391    6690    -701     
Flag Coverage Δ
php-unit-tests 59.4% <0.0%> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
google-listings-and-ads.php 7.7% <0.0%> (+1.4%) ⬆️
src/Google/GlobalSiteTag.php 0.0% <0.0%> (ø)

... and 100 files with indirect coverage changes

@puntope
Copy link
Contributor

puntope commented Dec 18, 2023

What's Changed

[Add] New Features 🎉

[Update] Updated ✨

[Fix] Fixes 🛠

[Tweak] Tweaked 🔧

Full Changelog: 2.5.13...2.5.14

@puntope puntope merged commit e2aba60 into trunk Dec 18, 2023
@puntope puntope deleted the release/2.5.14 branch December 18, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants