Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to require Google Ads connection during the onboarding #2180

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Change to require Google Ads connection during the onboarding #2180

merged 8 commits into from
Dec 15, 2023

Commits on Dec 13, 2023

  1. Change the onboarding to require a connected Google Ads account and m… 

    …ake its setup card always visible.
    @eason9487
    eason9487 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c792e42 View commit details
    Browse the repository at this point in the history

  2. Hide the content about the ad budget in the Boost card before a Googl… 

    …e Ads account is connected.
    @eason9487
    eason9487 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0aa954a View commit details
    Browse the repository at this point in the history

  3. Update tracking README.

    @eason9487
    eason9487 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ad3cb72 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Update budget recommendation text

    @martynmjones @eason9487
    martynmjones authored and eason9487 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ab228ba View commit details
    Browse the repository at this point in the history

  2. Fix the budget recommendation E2E tests for PR #2153 after cherry-pic… 

    …king PR #2174.

Ref:
- #2153
- #2174 (review)
    @eason9487
    eason9487 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ea809f5 View commit details
    Browse the repository at this point in the history

  3. Add more utils to mock requests for E2E tests.

    @eason9487
    eason9487 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    27f7c05 View commit details
    Browse the repository at this point in the history

  4. Adjust E2E tests to reflect the change of requiring Google Ads connec… 

    …tion in step 4 of the onboarding.
    @eason9487
    eason9487 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b4421aa View commit details
    Browse the repository at this point in the history

  5. Fix the problem that E2E util checkFAQExpandable doesn't wait for t… 

    …he page to load to proceed with assertions.
    @eason9487
    eason9487 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    368bb0c View commit details
    Browse the repository at this point in the history