Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes # .
E2E tests are failing due to the fact that the shop page and product items are blockified when utilizing the twenty twenty three template. See here: https://github.com/woocommerce/google-listings-and-ads/actions/runs/5794717342/job/15705036856?pr=2049
For instance, when using the twenty twenty three template, the "add to cart" option appears as a button:
<button href="?add-to-cart=34" class="wp-block-button__link wp-element-button wc-block-components-product-button__button add_to_cart_button ajax_add_to_cart product_type_simple has-font-size has-small-font-size has-text-align-center added" style="margin-bottom:1rem;" data-product_id="34" data-product_sku="" aria-label="Add “Simple product” to your cart" rel="nofollow">Add to cart</button><a href="http://localhost:8889/cart/" class="added_to_cart wc-forward" title="View cart">View cart</a>
In contrast, when it is not blockified is rendered as a link:
<a href="?add-to-cart=12" data-quantity="1" class="button product_type_simple add_to_cart_button ajax_add_to_cart" data-product_id="12" data-product_sku="" aria-label="Add “Simple product” to your cart" aria-describedby="" rel="nofollow">Add to cart</a>
And the shopper utility from the e2e utils package is expecting a link: https://github.com/woocommerce/woocommerce/blob/trunk/packages/js/e2e-utils/src/flows/shopper.js#L45C23-L45C23
As a result, causing the tests to not pass.
This PR sets the theme to
twentytwentyone
which does not use blocks.Screenshots:
Detailed test instructions:
Additional details:
Changelog entry