Skip to content

Commit

Permalink
Fix unecessary page wait.
Browse files Browse the repository at this point in the history
  • Loading branch information
asvinb committed Sep 5, 2024
1 parent b884b97 commit 5ec87d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export default function SetupPaidAds() {
return (
<AppButton
isTertiary
data-action={ ACTION_SKIP }
text={ text }
loading={ completing === ACTION_SKIP }
disabled={ disabledSkip }
Expand Down
3 changes: 1 addition & 2 deletions tests/e2e/utils/pages/setup-mc/step-4-complete-campaign.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,11 @@ export default class CompleteCampaign extends MockRequests {
/**
* Clicks the "Cancel" button in the skip paid ads creation modal.
*
* @return {Promise<void>} Resolves when the click action is completed and the page has loaded.
* @return {Promise<void>} Resolves when the click action is completed.
*/
async clickCancelModalButton() {
const button = this.getCancelModalButton();
await button.click();
await this.page.waitForLoadState( LOAD_STATE.DOM_CONTENT_LOADED );
}

/**
Expand Down

0 comments on commit 5ec87d6

Please sign in to comment.