Skip to content

Commit

Permalink
Merge pull request #318 from OrEvorn/master
Browse files Browse the repository at this point in the history
fix android build issues with react-native-pdf and react-native 59.x
  • Loading branch information
wonday authored Mar 26, 2019
2 parents 1404e4a + f1ddb54 commit 6c571b1
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ android {
compileSdkVersion _compileSdkVersion
buildToolsVersion _buildToolsVersion

packagingOptions {
pickFirst 'lib/x86/libc++_shared.so'
pickFirst 'lib/x86_64/libjsc.so'
pickFirst 'lib/arm64-v8a/libjsc.so'
pickFirst 'lib/arm64-v8a/libc++_shared.so'
pickFirst 'lib/x86_64/libc++_shared.so'
pickFirst 'lib/armeabi-v7a/libc++_shared.so'
}

This comment has been minimized.

Copy link
@alpha0010

alpha0010 Mar 29, 2019

Contributor

I think a better option would be to state in the readme to add the following android/app/build.gradle to the android section.

    packagingOptions {
        pickFirst 'lib/*/libc++_shared.so'
    }

The fix in this commit does not seem to help.


defaultConfig {
minSdkVersion _minSdkVersion
targetSdkVersion _targetSdkVersion
Expand Down

0 comments on commit 6c571b1

Please sign in to comment.