Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to steamcmd/steamcmd:ubuntu-24 #334

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

goofball222
Copy link
Contributor

  • Move the ENV section ahead of the RUN sections in the Dockerfile to be able to use the preset PGID and PUID.
  • Move DEBIAN_FRONTEND=noninteractive to ENV section.
  • Solve for UID & GID 1000 already in use by removing ubuntu user & group. userdel handles both in one command.
  • Create steam group and user with PGID and PUID from ENV vars, default 1000.
  • Add tzdata package to insure Docker TZ environment variable functions. Without tzdata the container doesn't know how to apply timezone changes / offsets.

Solve for UID & GID 1000 already in use by removing ubuntu user & group.

Create steam group and user with PGID and PUID from ENV vars, default 1000.

Also adds tzdata package to insure Docker TZ environment variable functions.
@wolveix
Copy link
Owner

wolveix commented Sep 26, 2024

Hey @goofball222! Apologies for not reviewing this yet. I'm very hesitant with rebasing the image, after the slew of issues it caused before. I'll properly review this once I can find the time to adequately test it out :) Thanks!

@goofball222
Copy link
Contributor Author

Anecdotally, I've been running a server off a build of this Dockerfile since I submitted the PR. No issues so far that I've noticed. Server has been through several restarts, etc.

No worries, take your time on review and / or feel free to close this out. Just wanted to share my solution to the reported problems with UID/GID conflicts reported from the first go-round with the Ubuntu 24 base.

@wolveix wolveix merged commit ffeac26 into wolveix:main Dec 4, 2024
2 checks passed
@wolveix
Copy link
Owner

wolveix commented Dec 4, 2024

Thanks for waiting! I'm going to release this as v1.9.0 and see how we go :) Great stuff!

wolveix added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants