Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated memory limitiations (based on update 8) #200

Merged
merged 9 commits into from
Nov 19, 2023
Merged

updated memory limitiations (based on update 8) #200

merged 9 commits into from
Nov 19, 2023

Conversation

DenuxPlays
Copy link
Contributor

I loaded up a bigger safe and the server didn't consumed more than 4GB (so I updated to 5GB)

This only applies to update 8 so this PR is draft atm until update 8 gets released to the early access branche.

Closes: #198

@DenuxPlays
Copy link
Contributor Author

The wiki should update once update 8 is released.

@wolveix wolveix marked this pull request as ready for review November 14, 2023 17:27
@kaflan
Copy link

kaflan commented Nov 16, 2023

@DenuxPlays 16G -> 5G upgrade? seriosly?
@wolveix it work correctly?

@wolveix
Copy link
Owner

wolveix commented Nov 16, 2023

@kaflan update 7 is what increased the RAM requirement to what it was, update 8 brought it back down to what it was. I'm waiting for the official wiki to reflect this change now that uodate 8 is in early access

@DenuxPlays
Copy link
Contributor Author

@DenuxPlays 16G -> 5G upgrade? seriosly?

@wolveix it work correctly?

Yes!
But I suggest that we check if 5Gigs is still enough.
They pushed a lot of releases in meantime (including updating the engine to 5.2 I think) so I would check if 5GB is still enough bevore merging this.

README.md Outdated
@@ -84,7 +84,7 @@ services:
deploy:
resources:
limits:
memory: 16G
memory: 5G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest setting the reservation to 5 and leaving the limit at 16. This will not deploy as the limit is lower than the reservation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes you're right must have forgotten this...
  2. I wouldn't leave the imit by 16

I ran some tests:
On a mid game safe game the server consumes between 2 and 4GB of RAM in endgame its like 4 to 5GB.
I'll update the numbers to this but it would be great if someone else could also test this to backup (or not refute) the numbers.

@DenuxPlays DenuxPlays requested a review from protoz November 17, 2023 07:38
README.md Outdated Show resolved Hide resolved
Co-authored-by: Dave Hoffman <[email protected]>
Copy link
Contributor

@protoz protoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wolveix wolveix merged commit a0019ec into wolveix:main Nov 19, 2023
1 of 2 checks passed
@wolveix
Copy link
Owner

wolveix commented Nov 19, 2023

Thanks again!

@DenuxPlays DenuxPlays deleted the enh/updated_memory branch November 19, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 8 Consumes Considerably Lower Memory
4 participants