Add otel-plugin-nginx, otel-cpp #30305
Conversation
wlynch
force-pushed
the
otel-nginx
branch
5 times, most recently
from
b525449
to
f4b90f4
Compare
Removes upb which is causing issues with downstream dependencies (otel-nginx - see #30305). This is documented as being an [internal dependency of grpc](https://github.com/protocolbuffers/protobuf/blob/6690ab42d855ea19d9a24cd99b0375910ea772ca/cmake/libupb.cmake#L14-L15). I did a spot check locally and py3-protobuf and php-protobuf can still build. Related: chainguard-dev/image-requests#4407, #30305 There is a newer version of protobuf available, but this breaks other packages and requires additional changes.
wlynch
force-pushed
the
otel-nginx
branch
3 times, most recently
from
75f661e
to
a88f7ab
Compare
- Adds opentelemetry-cpp: c++ client for otel (dependency for otel-plugin-nginx). - Adds otel-plugin-nginx
| cmake --install . --prefix ${{targets.contextdir}}/usr | ||
|
|
||
| - uses: strip | ||
|
|
There was a problem hiding this comment.
Any docs/infodirs we can split into subpackages, development files. etc?
There was a problem hiding this comment.
Yeah I was wondering about this - I didn't see any documentation about this in the wiki. What are the common subpackage breakdowns we aim for, what kinds of files go in them, and what naming conventions should each subpackage have?
Here's the file extension breakdown for files in the package:
4 cmake
7 pc
18 so
334 h
I can probably break out the headers, but what about cmake/pc? Are those considered development files, or should they go in a separate package?
There was a problem hiding this comment.
We have pipelines in melange that can be used to split things away: https://github.com/chainguard-dev/melange/tree/main/pkg/build/pipelines/split
Typically, we split whatever we can. I.E., those headers (the .h files) would be split away with split/dev and docs would be split with split/manpages and split/info if an info directory exists. It looks like in your case, you just need to create a -dev subpackage that uses the split/dev pipeline
Note
This is the community otel nginx plugin that was used in ingress-nginx. This is not the official nginx otel plugin.
Related: https://github.com/chainguard-dev/image-requests/issues/4407
Pre-review Checklist
For new package PRs only
endoflife.date)