Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falco/0.38.2 package update #26622

Closed
wants to merge 8 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Aug 19, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Aug 19, 2024
@octo-sts octo-sts bot mentioned this pull request Aug 19, 2024
Copy link
Contributor Author

octo-sts bot commented Aug 19, 2024

Open AI suggestions to solve the build error:

The error message is: 

ERRO ERROR: failed to build package. the build environment has been preserved:
INFO workspace dir: /temp/melange-workspace-2790553255
INFO guest dir: /temp/melange-guest-2888924433
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 1
make[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2


Suggested actions:
1. Check logs in `/temp/melange-workspace-2790553255` and `/temp/melange-guest-2888924433`.
2. Ensure all dependencies are installed.
3. Verify `Makefile` targets and paths.
4. Run `make clean`.
5. Retry the build.
6. Update or patch `falco` if needed.

Copy link
Contributor Author

octo-sts bot commented Aug 19, 2024

Open AI suggestions to solve the build error:

The error message is: "fatal: detected dubious ownership in repository at '/github/home'
To add an exception for this directory, call:

git config --global --add safe.directory /github/home
ERRO request failed error=\"Get \\\"./packages/apk-configuration\\\": unsupported protocol scheme \\\"\\\"\" method=GET url=./packages/apk-configuration
ERRO ERROR: failed to build package. the build environment has been preserved:
INFO   workspace dir: /temp/melange-workspace-3527918862
INFO   guest dir: /temp/melange-guest-2260402964
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 1
make[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2"

To fix this error:
1. Run `git config --global --add safe.directory /github/home`.
2. Ensure the URL in the GET request uses a supported protocol (e.g., `http://` or `https://`).
3. Verify the build environment and dependencies for the `falco` package.
4. Ensure all required tools and permissions are correctly set up in the build environment.

Copy link
Contributor Author

octo-sts bot commented Aug 19, 2024

Open AI suggestions to solve the build error:

The error message is: 
"ERRO request failed error=\"Get \\\"./packages/apk-configuration\\\": unsupported protocol scheme \\\"\\\"\" method=GET url=./packages/apk-configuration\nERRO ERROR: failed to build package. the build environment has been preserved:\nINFO   workspace dir: /temp/melange-workspace-3321453030\nINFO   guest dir: /temp/melange-guest-221387403\nERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 1\nmake[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1\nmake[1]: Leaving directory '/github/home'\nmake: *** [Makefile:101: package/falco] Error 2\n##[error]Process completed with exit code 2."

To fix this error:
1. Ensure the URL in the GET request is correct and includes a valid protocol (e.g., `http://` or `https://`).
2. Verify the `Makefile` paths and targets are correct.
3. Check the build environment and dependencies.
4. Ensure all required files and directories are present.
5. Re-run the build process.

@TaylorBloom129 TaylorBloom129 added the help wanted Extra attention is needed label Aug 26, 2024
@srishtih
Copy link
Contributor

The patch needs to be updated, likely. Looking into it.

This was referenced Aug 26, 2024
EyeCantCU pushed a commit that referenced this pull request Aug 26, 2024
Added to provided runtime dependency for falco
#26622

---------

Signed-off-by: Srishti Hegde <[email protected]>
EyeCantCU pushed a commit that referenced this pull request Aug 26, 2024
Added to provided runtime dependency for falco
#26622

---------

Signed-off-by: Srishti Hegde <[email protected]>
@cpanato cpanato force-pushed the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch from db7ab76 to 57f27b4 Compare August 29, 2024 12:50
Copy link
Contributor Author

octo-sts bot commented Aug 29, 2024

Open AI suggestions to solve the build error:

The error message is: "The imported target 'protobuf::libprotobuf' references the file '/usr/lib/libprotobuf.so.27.4.0' but this file does not exist."

1. Verify if protobuf is installed: `protoc --version`.
2. If not installed, install it: `sudo apt-get install protobuf-compiler libprotobuf-dev`.
3. If installed, locate the correct path: `find /usr -name libprotobuf.so*`.
4. Update the CMakeLists.txt or environment variables to point to the correct path of libprotobuf.

@cpanato cpanato force-pushed the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch 3 times, most recently from ad4cd0a to b9b83f6 Compare August 29, 2024 13:08
Copy link
Contributor Author

octo-sts bot commented Aug 29, 2024

Open AI suggestions to solve the build error:

The error message is: "The imported target 'protobuf::libprotobuf' references the file '/usr/lib/libprotobuf.so.27.4.0' but this file does not exist."

1. Verify if protobuf is installed: `protoc --version`.
2. If not installed, install it: `sudo apt-get install protobuf-compiler libprotobuf-dev`.
3. If installed, locate the correct path: `find /usr -name libprotobuf.so*`.
4. Update the CMakeLists.txt or environment variables to point to the correct path of libprotobuf.

1 similar comment
Copy link
Contributor Author

octo-sts bot commented Aug 29, 2024

Open AI suggestions to solve the build error:

The error message is: "The imported target 'protobuf::libprotobuf' references the file '/usr/lib/libprotobuf.so.27.4.0' but this file does not exist."

1. Verify if protobuf is installed: `protoc --version`.
2. If not installed, install it: `sudo apt-get install protobuf-compiler libprotobuf-dev`.
3. If installed, locate the correct path: `find /usr -name libprotobuf.so*`.
4. Update the CMakeLists.txt or environment variables to point to the correct path of libprotobuf.

@cpanato cpanato force-pushed the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch from b9b83f6 to 25ba663 Compare August 29, 2024 13:18
Copy link
Contributor Author

octo-sts bot commented Aug 29, 2024

Open AI suggestions to solve the build error:

The error message is: "The imported target 'protobuf::libprotobuf' references the file '/usr/lib/libprotobuf.so.27.4.0' but this file does not exist."

1. Verify if protobuf is installed: `protoc --version`.
2. If not installed, install it: `sudo apt-get install protobuf-compiler libprotobuf-dev`.
3. If installed, locate the correct path: `find /usr -name libprotobuf.so*`.
4. Update the CMakeLists.txt or environment variables to point to the correct path of libprotobuf.

falco.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

octo-sts bot commented Sep 3, 2024

Open AI suggestions to solve the build error:

The error message is: "The imported target 'protobuf::libprotobuf' references the file '/usr/lib/libprotobuf.so.27.4.0' but this file does not exist."

1. Verify if protobuf is installed: `protoc --version`.
2. If not installed, install it: `sudo apt-get install protobuf-compiler libprotobuf-dev`.
3. If installed, locate the correct path: `find /usr -name libprotobuf.so*`.
4. Update the CMakeLists.txt or environment variables to point to the correct path.
5. Rebuild the project.

grpc.yaml Outdated Show resolved Hide resolved
falco/tbb.patch Show resolved Hide resolved
Copy link
Contributor Author

octo-sts bot commented Sep 16, 2024

Open AI suggestions to solve the build error:

The error message is:

WARN /usr/lib/gcc/aarch64-unknown-linux-gnu/14/../../../../aarch64-unknown-linux-gnu/bin/ld: ../engine/libfalco_engine.a(formats.cpp.o): undefined reference to symbol '_ZN4Json5ValueixEPKc'
WARN /usr/lib/gcc/aarch64-unknown-linux-gnu/14/../../../../aarch64-unknown-linux-gnu/bin/ld: /usr/lib/libjsoncpp.so.26: error adding symbols: DSO missing from command line
WARN collect2: error: ld returned 1 exit status
WARN make[3]: *** [userspace/falco/CMakeFiles/falco.dir/build.make:315: userspace/falco/falco] Error 1
WARN make[2]: *** [CMakeFiles/Makefile2:1649: userspace/falco/CMakeFiles/falco.dir/all] Error 2
WARN make[1]: *** [CMakeFiles/Makefile2:1656: userspace/falco/CMakeFiles/falco.dir/rule] Error 2
WARN make: *** [Makefile:722: falco] Error 2
ERRO ERROR: failed to build package. the build environment has been preserved:
INFO workspace dir: /temp/melange-workspace-1948109124
INFO guest dir: /temp/melange-guest-3924866591
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 2
make[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2
##[error]Process completed with exit code 2.


To fix this error:
1. Open the `CMakeLists.txt` file.
2. Locate the target link libraries section for `falco`.
3. Add `jsoncpp` to the list of linked libraries:
   ```cmake
   target_link_libraries(falco jsoncpp)
  1. Save the file and re-run the build process.

Copy link
Contributor Author

octo-sts bot commented Sep 16, 2024

Open AI suggestions to solve the build error:

The error message is: "ERROR: failed to build package. the build environment has been preserved:
INFO   workspace dir: /temp/melange-workspace-1962351750
INFO   guest dir: /temp/melange-guest-4225367656
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 2
make[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2
##[error]Process completed with exit code 2."

1. Check the Makefile at lines 101 and 111 for errors.
2. Ensure all dependencies for building 'falco' are installed.
3. Verify the build environment paths are correct.
4. Run the build command manually to see detailed error output.
5. Check for any missing or incorrect configurations in the build scripts.

@xnox
Copy link
Contributor

xnox commented Sep 16, 2024

flips tables

Copy link
Contributor Author

octo-sts bot commented Sep 17, 2024

Open AI suggestions to solve the build error:

The error message is: "ERROR: failed to build package. the build environment has been preserved:
INFO   workspace dir: /temp/melange-workspace-1515849253
INFO   guest dir: /temp/melange-guest-3586271612
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 2
make[1]: *** [Makefile:111: packages/x86_64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2
##[error]Process completed with exit code 2."

1. Verify dependencies are installed.
2. Check for errors in the Makefile at lines 101 and 111.
3. Ensure the build environment is correctly set up.
4. Review the build logs for specific errors.
5. Run `make clean` and retry the build.
6. Update or reinstall the falco package if necessary.

Copy link
Contributor Author

octo-sts bot commented Sep 17, 2024

Open AI suggestions to solve the build error:

The error message is:

WARN /usr/lib/gcc/aarch64-unknown-linux-gnu/14/../../../../aarch64-unknown-linux-gnu/bin/ld: ../engine/libfalco_engine.a(formats.cpp.o): undefined reference to symbol '_ZN4Json5ValueixEPKc'
WARN /usr/lib/gcc/aarch64-unknown-linux-gnu/14/../../../../aarch64-unknown-linux-gnu/bin/ld: /usr/lib/libjsoncpp.so.26: error adding symbols: DSO missing from command line
WARN collect2: error: ld returned 1 exit status
WARN make[3]: *** [userspace/falco/CMakeFiles/falco.dir/build.make:315: userspace/falco/falco] Error 1
WARN make[2]: *** [CMakeFiles/Makefile2:1649: userspace/falco/CMakeFiles/falco.dir/all] Error 2
WARN make[1]: *** [CMakeFiles/Makefile2:1656: userspace/falco/CMakeFiles/falco.dir/rule] Error 2
WARN make: *** [Makefile:722: falco] Error 2
ERRO ERROR: failed to build package. the build environment has been preserved:
INFO workspace dir: /temp/melange-workspace-1191945199
INFO guest dir: /temp/melange-guest-2708725637
ERRO failed to build package: unable to run package falco pipeline: unable to run pipeline: unable to run pipeline: exit status 2
make[1]: *** [Makefile:111: packages/aarch64/falco-0.38.2-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/falco] Error 2
##[error]Process completed with exit code 2.


To fix this error:
1. Open the `CMakeLists.txt` file.
2. Locate the target link libraries section for `falco`.
3. Add `jsoncpp` to the list of linked libraries:
   ```cmake
   target_link_libraries(falco jsoncpp)
  1. Save the file and re-run the build process.

Copy link
Contributor Author

octo-sts bot commented Sep 30, 2024

Open AI suggestions to solve the build error:

No errors were found in the last 280 lines of the log file at `/tmp/script83015441`.

@rawlingsj rawlingsj force-pushed the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch from a3bf15a to 2c12a17 Compare September 30, 2024 13:04
Copy link
Contributor Author

octo-sts bot commented Sep 30, 2024

Open AI suggestions to solve the build error:

The error message is: "In function 'ZSTD_decompressSequences', inlined from 'ZSTD_decompressBlock' at /home/build/lib/legacy/zstd_v01.c:1904:12: /home/build/lib/legacy/zstd_v01.c:1850:35: warning: 'dumpsLength' may be used uninitialized [-Wmaybe-uninitialized] /home/build/lib/legacy/zstd_v01.c:1826:23: note: 'dumpsLength' was declared here /home/build/lib/legacy/zstd_v01.c:1850:35: warning: 'dumps' may be used uninitialized [-Wmaybe-uninitialized] /home/build/lib/legacy/zstd_v01.c:1830:17: note: 'dumps' was declared here /home/build/lib/legacy/zstd_v01.c:1858:83: warning: 'nbSeq' may be used uninitialized [-Wmaybe-uninitialized] /home/build/lib/legacy/zstd_v01.c: In function 'ZSTD_decompressBlock': /home/build/lib/legacy/zstd_v01.c:1829:9: note: 'nbSeq' was declared here"

To fix this error:
1. Initialize `dumpsLength`, `dumps`, and `nbSeq` to default values (e.g., 0 or NULL) at their declaration points.
2. Ensure these variables are properly assigned before use.
3. Add checks to handle cases where these variables might remain uninitialized.

Example:
```c
size_t dumpsLength = 0;
void* dumps = NULL;
size_t nbSeq = 0;

@rawlingsj rawlingsj force-pushed the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch from 2c12a17 to 8fabc47 Compare September 30, 2024 14:01
Copy link
Contributor Author

octo-sts bot commented Sep 30, 2024

Open AI suggestions to solve the build error:

No errors were found in the log file.

@rawlingsj
Copy link
Member

Latest issue fails only on x86 builds (arm is green yay)...

2024/09/30 14:04:28 WARN /home/build/build/falcosecurity-libs-repo/falcosecurity-libs-prefix/src/falcosecurity-libs/userspace/libscap/engine/gvisor/parsers.cpp:31:10: fatal error: driver/syscall_compat_x86_64.h: No such file or directory
2024/09/30 14:04:28 WARN    31 | #include <driver/syscall_compat_x86_64.h>
2024/09/30 14:04:28 WARN       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024/09/30 14:04:28 WARN compilation terminated.

It builds locally if I add this to the cmake config options

-DBUILD_FALCO_GVISOR=OFF

But that sounds a bit extreme as the build must have worked before. The original config to build x86 with gvisor was added 2 years ago.

@xnox
Copy link
Contributor

xnox commented Sep 30, 2024

Latest issue fails only on x86 builds (arm is green yay)...

2024/09/30 14:04:28 WARN /home/build/build/falcosecurity-libs-repo/falcosecurity-libs-prefix/src/falcosecurity-libs/userspace/libscap/engine/gvisor/parsers.cpp:31:10: fatal error: driver/syscall_compat_x86_64.h: No such file or directory
2024/09/30 14:04:28 WARN    31 | #include <driver/syscall_compat_x86_64.h>
2024/09/30 14:04:28 WARN       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024/09/30 14:04:28 WARN compilation terminated.

It builds locally if I add this to the cmake config options

-DBUILD_FALCO_GVISOR=OFF

But that sounds a bit extreme as the build must have worked before. The original config to build x86 with gvisor was added 2 years ago.

is the build going too fast? and the generated file is not there yet? Can one somehow do "make driver/syscall_compat_x86_64.h" first? or even force the build to be linear?

@rawlingsj
Copy link
Member

is the build going too fast? and the generated file is not there yet? Can one somehow do "make driver/syscall_compat_x86_64.h" first? or even force the build to be linear?

I don't think so, it seems related to #26622 (comment)

Copy link
Contributor Author

octo-sts bot commented Sep 30, 2024

Open AI suggestions to solve the build error:

No errors were found in the last 280 lines of the log file.

…es the right paths until upstream PR merges

Signed-off-by: James Rawlings <[email protected]>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Sep 30, 2024
@rawlingsj rawlingsj closed this Sep 30, 2024
@rawlingsj rawlingsj reopened this Sep 30, 2024
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@octo-sts octo-sts bot closed this Oct 1, 2024
Copy link
Contributor Author

octo-sts bot commented Oct 1, 2024

superseded by #29778

debasishbsws added a commit that referenced this pull request Oct 1, 2024
…e right paths until upstream PR merges

All the changes are taken from the last PR: #26622



Signed-off-by: Debasish Biswas <[email protected]>
@octo-sts octo-sts bot deleted the wolfictl-8a42d8f3-a448-4e2b-96b2-a495495a0191 branch October 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. help wanted Extra attention is needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants