Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix WOLFSSH_NO_RSA #650

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix WOLFSSH_NO_RSA #650

merged 2 commits into from
Jan 31, 2024

Conversation

miyazakh
Copy link
Contributor

Fix WOLFSSH_NO_RSA case
wolfssl
$ ./configure --enable-ssh --enable-rsa=no

wolfssh
$ ./configure --with-wolfssl=/usr/local/ CFLAGS="-DWOLFSSH_NO_RSA"

@miyazakh miyazakh mentioned this pull request Jan 27, 2024
Closed
@ejohnstown ejohnstown self-requested a review January 29, 2024 23:52
ejohnstown
ejohnstown requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ejohnstown ejohnstown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/internal.c: please move the #ifndef WOLFSSH_NO_RSA from before the function CalcRsaInverses() to before GetMpintToMp().

@ejohnstown ejohnstown assigned miyazakh and unassigned wolfSSL-Bot Jan 30, 2024
@ejohnstown ejohnstown self-requested a review January 30, 2024 00:03
@wolfSSL wolfSSL deleted a comment from miyazakh Jan 30, 2024
@ejohnstown ejohnstown merged commit 815d22f into wolfSSL:master Jan 31, 2024
10 checks passed
@miyazakh miyazakh deleted the no_rsa branch February 1, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejohnstown ejohnstown ejohnstown approved these changes

Assignees

@miyazakh miyazakh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miyazakh @ejohnstown @wolfSSL-Bot