Partial Success #571
Merged
Partial Success #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User authentication partial successes are controlled by the user authentication callback. If the public key is accepted by the user authentication callback, but considers it a partial success, the signature is still checked and if successful, is still treated as a failure in the response message. 1. Add new user authentication callback return value of WOLFSSH_USERAUTH_PARTIAL_SUCCESS. 2. Update the password user authentication function to parallel the public key version more. Treat failure and partial success similarly. 3. Check the public key user authentcation callback for partial success. In that case, still check the signature.
JacobBarthelmeh
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User authentication partial successes are controlled by the user authentication callback. If the public key is accepted by the user authentication callback, but considers it a partial success, the signature is still checked and if successful, is still treated as a failure in the response message.