fix file offest on Windows and change offset increment #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
assigned JacobBarthelmeh, dgarske and wolfSSL-Bot and unassigned JacobBarthelmeh
dgarske
reviewed
Aug 7, 2023
src/internal.c
Outdated
| @@ -13217,12 +13217,20 @@ int wolfSSH_oct2dec(WOLFSSH* ssh, byte* oct, word32 octSz) | |||
| } | |||
|
|
|||
|
|
|||
| /* not using UINT_MAX here because word32 should always be 32 bits where an | |||
| * int type can change depending on platform */ | |||
| #define WS_WORD32_MAX_SZ 4294967295U | |||
There was a problem hiding this comment.
Is it too ugly to use something like #define WS_WORD32_MAX_SZ (word32)((1ULL << (sizeof(word32)*4)) - 1)?
There was a problem hiding this comment.
Something like that would work. I get the idea, doing a bitshift to larger than the max size minus 1. Will make the change.
There was a problem hiding this comment.
Looking for WOLFSSL_BIT_SIZE (8) I see we have WOLFSSL_MAX_32BIT (0xffffffU), which is what I tried to find initially. Will try to use that instead of recreating it.
dgarske
previously approved these changes
Aug 7, 2023
dgarske
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via direct email. On Windows the high offset was not getting set with SFTP leading to not stopping when writing files larger than max word32 size (over 4G). When fixing that I also changed the assign function to not depend on overflow (undefined behavior) for incrementing the high offset value.