Merge pull request #668 from ejohnstown/fix-modes-leak

Fix Modes Leak
wolfSSL · Mar 14, 2024 · b798f63 · b798f63
2 parents f92b076 + e6ffad0
commit b798f63
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/internal.c b/src/internal.c
@@ -1017,6 +1017,12 @@ void SshResourceFree(WOLFSSH* ssh, void* heap)
         ssh->sftpDefaultPath = NULL;
     }
 #endif
+#ifdef WOLFSSH_TERM
+    if (ssh->modes) {
+        WFREE(ssh->modes, ssh->ctx->heap, DYNTYPE_STRING);
+        ssh->modesSz = 0;
+    }
+#endif
 }
 
 
@@ -7584,7 +7590,8 @@ static int DoChannelRequest(WOLFSSH* ssh,
             if (ret == WS_SUCCESS)
                 ret = GetStringRef(&modesSz, &modes, buf, len, &begin);
             if (ret == WS_SUCCESS) {
-                ssh->modes = (byte*)WMALLOC(modesSz, ssh->ctx->heap, 0);
+                ssh->modes = (byte*)WMALLOC(modesSz,
+                        ssh->ctx->heap, DYNTYPE_STRING);
                 if (ssh->modes == NULL)
                     ret = WS_MEMORY_E;
             }