Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sign/verify tests, eddsa support, refactoring of the KeyProvider api #13

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gasbytes
Copy link
Contributor

@gasbytes gasbytes commented Nov 27, 2024

This pull request includes several changes to the rustls-wolfcrypt-provider to improve key handling, add support for new algorithms, and clean up the codebase. The most important changes include modifying the key handling for ECDSA keys, adding support for Ed25519, and restructuring the sign module.

Key handling improvements:

  • Modified the EcdsaSigningKeyP256Sign, EcdsaSigningKeyP384Sign, and EcdsaSigningKeyP521Sign structures to store private key bytes instead of ECCKeyObject and updated their implementations accordingly (rustls-wolfcrypt-provider/src/sign/ecdsa.rs). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Support for new algorithms:

  • Added support for the Ed25519 algorithm in the sign module and updated the KeyProvider implementation to include Ed25519 (rustls-wolfcrypt-provider/src/lib.rs). [1] [2] [3]

Code restructuring:

  • Changed the sign module to make the eddsa submodule public and updated the key handling logic to use closures for defining supported algorithms (rustls-wolfcrypt-provider/src/lib.rs). [1] [2] [3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant