Better sign/verify tests, eddsa support, refactoring of the KeyProvider api #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
rustls-wolfcrypt-provider
to improve key handling, add support for new algorithms, and clean up the codebase. The most important changes include modifying the key handling for ECDSA keys, adding support for Ed25519, and restructuring thesign
module.Key handling improvements:
EcdsaSigningKeyP256Sign
,EcdsaSigningKeyP384Sign
, andEcdsaSigningKeyP521Sign
structures to store private key bytes instead ofECCKeyObject
and updated their implementations accordingly (rustls-wolfcrypt-provider/src/sign/ecdsa.rs
). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Support for new algorithms:
sign
module and updated theKeyProvider
implementation to include Ed25519 (rustls-wolfcrypt-provider/src/lib.rs
). [1] [2] [3]Code restructuring:
sign
module to make theeddsa
submodule public and updated the key handling logic to use closures for defining supported algorithms (rustls-wolfcrypt-provider/src/lib.rs
). [1] [2] [3]