Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not override config_sync_directory when already defined #103

Merged
merged 4 commits into from
Jun 29, 2024
Merged

feat: do not override config_sync_directory when already defined #103

merged 4 commits into from
Jun 29, 2024

Conversation

esolitos
Copy link
Contributor

What

Ensure that the setting config_sync_directory isn't already set before configuring it.

Why

  • This aligns with other settings which are only configured if a value isn't already set.
  • Ensures that no matter when wodby.settings.php is included it will not change it's behaviour
  • Allows setting a custom location for config_sync_directory

@csandanov csandanov merged commit 7884de6 into wodby:master Jun 29, 2024
9 checks passed
@esolitos esolitos deleted the patch-1 branch June 30, 2024 09:15
@esolitos
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esolitos @csandanov