-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helper to get dependency-groups #876
Conversation
Oh, I'm happy to add 3.8 support! In fact, rather than delaying, I just did in v1.1.0 . I'm not sure why I wasn't more conservative about the supported versions when creating the library, but I agree that was a mistake. |
Great, thanks! FWIW, I don't care if the latest version is 3.9+ (or 3.13+), I just need a working 3.8 version that gets pulled by 3.8. :) |
9343f3a
to
4dd622a
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
4dd622a
to
8129254
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
446b6d2
to
717116a
Compare
Starting work on #845.
I was going to use @sirosen's dependency-groups, but it only supports 3.9+ - even the first version was 3.9+. I don't think that was a great idea for a foundational utility, but it's what it is. So we can't use it yet. And this is pretty easy, I think we can just write our own support as long as it's tested.I've improved on the example implementation several ways:setdefault
is a safer thandefaultdict
. I've used generators to remove the appends and extends. And I've used*args
to simplify the past_groups handling.I think we can start with a function like this, and maybe eventually come up with a nicer interface for things in pyproject.toml. But this is simple and could be used by the fancier interface later.